Review main Merged

91775[TASK] Utilize PageContext API in View module

Oli Bartsch CR +2 V +2 Hard +323 −157 updated 11/21/25, 08:59

Commit message

The `ViewModuleController` is migrated to use
the new PageContext API, resulting in a heavily
simplified controller due to removal of custom
page, site, permission and TSconfig handling.

Additionally, the View module therefore now
benefits form the shared language feature.

Besides this, the patch further streamlines
the API:

* Page Module handles pid=0 correctly again
* Page Module properly uses localized page title
  for the module title tag
* Obsolete moduleData ("languages") definition removed

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Sebastian Iffland +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 12

Review log 1722

  1. Oli Bartsch uploaded patch set 1 11/20/25, 16:54

  2. core-ci voted on patch set 1 V -1 11/20/25, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90326

  3. Oli Bartsch uploaded patch set 2 V -1 11/20/25, 17:16

  4. core-ci voted on patch set 2 V +1 11/20/25, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90332

  5. Sebastian Iffland commented on patch set 2 11/20/25, 17:27

    code style proposal

    SharedUserPreferences.php:56

    I'd apply new style intval call with extraction pattern. ```suggestion return array_unique(array_map(intval(...), $requestLanguages)); ``` (Already applied in 27 files → https://github.com/search?q=repo%3ATYPO3%2Ftypo3%20%22intval(...)%22&type=code)

    SharedUserPreferences.php:67

    I'd apply new style intval call with extraction pattern. ```suggestion return array_unique(array_map(intval(...), $moduleDataLanguages)); ```
  6. Oli Bartsch commented on patch set 2 11/20/25, 18:28

    SharedUserPreferences.php:56 Reply

    What is the benefit? We also still use `'intval'` a lot: https://github.com/search?q=repo:TYPO3/typo3+%22'intval'%22&type=code
  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/20/25, 21:47

  8. Andreas Kienast commented on patch set 2 V -1 11/21/25, 06:39

    The "Edit page properties" vanishes now on pid 0 in the "Page" module (which is good), but is still present in the "List" module.
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 11/21/25, 06:53

  10. core-ci voted on patch set 3 V +1 11/21/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90446

  11. Andreas Kienast commented on patch set 3 11/21/25, 07:11

    Reply

    Done
  12. Andreas Kienast commented on patch set 3 11/21/25, 07:12

    SharedUserPreferences.php:56 Reply

    > The advantage of this syntax is that it is accessible to static analysis, and uses the scope at the point where the callable is acquired. — https://www.php.net/manual/en/functions.first_class_callable_syntax.php
  13. Oli Bartsch uploaded patch set 4 V +1 11/21/25, 08:36

  14. Oli Bartsch commented on patch set 4 11/21/25, 08:37

    Reply

    Done

    SharedUserPreferences.php:56 Reply

    Done

    SharedUserPreferences.php:67 Reply

    Done
  15. Oli Bartsch updated the commit message in patch set 5 11/21/25, 08:42

  16. Andreas Kienast voted on patch set 5 CR +1 V +1 11/21/25, 08:42

  17. Sebastian Iffland voted on patch set 5 CR +1 11/21/25, 08:45

  18. core-ci voted on patch set 4 V +1 11/21/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90457

  19. Georg Ringer voted on patch set 5 CR +1 V +1 11/21/25, 08:46

  20. core-ci voted on patch set 5 V +1 11/21/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90460

  21. Oli Bartsch voted on patch set 5 CR +2 V +2 11/21/25, 08:59

  22. Oli Bartsch merged patch set 6 11/21/25, 08:59