91775[TASK] Utilize PageContext API in View module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Sebastian Iffland +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 3
Files 12
- typo3/sysext/backend/Classes/Context/PageContextFactory.php+6 −15
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+10 −18
- typo3/sysext/backend/Classes/Controller/RecordListController.php+2 −6
- typo3/sysext/backend/Classes/User/SharedUserPreferences.php6+5 −5
- typo3/sysext/backend/Configuration/Backend/Modules.php+0 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-108016-MultiLanguageSelectionInPageAndListModules.rst+7 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+70 −108
- typo3/sysext/viewpage/Configuration/Backend/Modules.php+0 −3
- typo3/sysext/viewpage/Tests/Fixtures/be_users.csvnew+3 −0
- typo3/sysext/viewpage/Tests/Fixtures/pages_languages.csvnew+6 −0
- typo3/sysext/viewpage/Tests/Functional/Controller/ViewModuleControllerTest.phpnew+213 −0
- composer.json+1 −0
Review log 1722
-
Oli Bartsch uploaded patch set 1 11/20/25, 16:54
-
core-ci voted on patch set 1 V -1 11/20/25, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90326
-
Oli Bartsch uploaded patch set 2
V -111/20/25, 17:16 -
core-ci voted on patch set 2 V +1 11/20/25, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90332
-
Sebastian Iffland commented on patch set 2 11/20/25, 17:27
code style proposalSharedUserPreferences.php:56I'd apply new style intval call with extraction pattern. ```suggestion return array_unique(array_map(intval(...), $requestLanguages)); ``` (Already applied in 27 files → https://github.com/search?q=repo%3ATYPO3%2Ftypo3%20%22intval(...)%22&type=code)SharedUserPreferences.php:67I'd apply new style intval call with extraction pattern. ```suggestion return array_unique(array_map(intval(...), $moduleDataLanguages)); ``` -
Oli Bartsch commented on patch set 2 11/20/25, 18:28
SharedUserPreferences.php:56ReplyWhat is the benefit? We also still use `'intval'` a lot: https://github.com/search?q=repo:TYPO3/typo3+%22'intval'%22&type=code -
Georg Ringer voted on patch set 2 CR +1 V +1 11/20/25, 21:47
-
Andreas Kienast commented on patch set 2 V -1 11/21/25, 06:39
The "Edit page properties" vanishes now on pid 0 in the "Page" module (which is good), but is still present in the "List" module. -
Andreas Kienast uploaded patch set 3
CR +1V +111/21/25, 06:53 -
core-ci voted on patch set 3 V +1 11/21/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90446
-
Andreas Kienast commented on patch set 3 11/21/25, 07:11
Reply
Done -
Andreas Kienast commented on patch set 3 11/21/25, 07:12
SharedUserPreferences.php:56Reply> The advantage of this syntax is that it is accessible to static analysis, and uses the scope at the point where the callable is acquired. — https://www.php.net/manual/en/functions.first_class_callable_syntax.php -
Oli Bartsch uploaded patch set 4
V +111/21/25, 08:36 -
Oli Bartsch commented on patch set 4 11/21/25, 08:37
Reply
DoneSharedUserPreferences.php:56ReplyDoneSharedUserPreferences.php:67ReplyDone -
Oli Bartsch updated the commit message in patch set 5 11/21/25, 08:42
-
Andreas Kienast voted on patch set 5 CR +1 V +1 11/21/25, 08:42
-
Sebastian Iffland voted on patch set 5 CR +1 11/21/25, 08:45
-
core-ci voted on patch set 4 V +1 11/21/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90457
-
Georg Ringer voted on patch set 5 CR +1 V +1 11/21/25, 08:46
-
core-ci voted on patch set 5 V +1 11/21/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90460
-
Oli Bartsch voted on patch set 5 CR +2 V +2 11/21/25, 08:59
-
Oli Bartsch merged patch set 6 11/21/25, 08:59