91776[BUGFIX] Remove duplicated language file for View module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
- Sven Liebert +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
- Sven Liebert +1
- core-ci +1 CI
Issues 2
Files 2
Review log 2128
Show 23 earlier messages
-
Oli Bartsch uploaded patch set 1 11/20/25, 17:10
-
core-ci voted on patch set 1 V +1 11/20/25, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90331
-
Oli Bartsch uploaded patch set 2
V +111/20/25, 17:32
-
core-ci voted on patch set 2 V +1 11/20/25, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90335
-
Oli Bartsch uploaded patch set 3
V +111/20/25, 17:51 -
core-ci voted on patch set 3 V +1 11/20/25, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90341
-
Lina Wolf voted on patch set 3 CR +1 V +1 11/21/25, 09:46
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/21/25, 09:48
-
Lina Wolf commented on patch set 3 CR -1 11/21/25, 09:50
Working on it -
Lina Wolf uploaded patch set 4
CR +1V +111/21/25, 09:52 -
Lina Wolf commented on patch set 4 CR +1 V +1 11/21/25, 09:53
Sorry, found another usage, fixed it -
Georg Ringer voted on patch set 4 CR +1 V +1 11/21/25, 09:54
-
core-ci voted on patch set 4 V +1 11/21/25, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90475
-
Oli Bartsch commented on patch set 4 V -1 11/21/25, 10:45
I’d prefer to keep this on hold until we make a final decision on how module labels should be defined. Right now, we have two patterns: `Language/module.xlf` and `Language/Modules/<name>.xlf`. As I understand it, the idea was: * Use `Language/module.xlf if` an extension provides only a single module. * Use `Language/Modules/<name>.xlf` if an extension defines multiple modules or submodules. My concern is that this distinction is not intuitive and becomes problematic once an extension later decides to add a second module => the structure suddenly needs to change. My suggestion is to consistently use `Language/Modules/<module_identifier>.xlf` for all modules. This makes the structure predictable, avoids future migration issues, and would as side effect also enable autodiscovery. -
Lina Wolf commented on patch set 4 11/21/25, 10:49
Reply
We should resolve this duplicate file before 14.0 release, otherwise both will be published and translators will start to translate them. Some might not notice there are two files -
Lina Wolf commented on patch set 4 CR -1 11/21/25, 16:12
Working on it -
Lina Wolf uploaded patch set 5
CR +1V +111/21/25, 16:15 -
Lina Wolf voted on patch set 5 CR +1 V +1 11/21/25, 16:16
-
Lina Wolf uploaded patch set 6
CR +1V +111/21/25, 16:18 -
Lina Wolf uploaded patch set 7 11/21/25, 16:19
-
core-ci voted on patch set 5 V -1 11/21/25, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90546
-
core-ci voted on patch set 6 V -1 11/21/25, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90547
-
core-ci voted on patch set 7 V +1 11/21/25, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90548
-
Lina Wolf voted on patch set 7 CR +1 V +1 11/21/25, 16:34
-
Sven Liebert voted on patch set 7 CR +1 V +1 11/21/25, 16:46
-
Garvin Hicking voted on patch set 7 CR +1 V +1 11/21/25, 18:55
-
Oli Bartsch commented on patch set 7 CR +2 V +2 11/21/25, 19:47
Reply
Done -
Oli Bartsch merged patch set 8 11/21/25, 19:47