91783[TASK] Remove superfluous readonly declaration in AsAllowedCallable
Commit message
Review
-
Code review CR -1
- Christian Kuhn -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 56
-
Oliver Hader uploaded patch set 1 11/20/25, 18:47
-
core-ci voted on patch set 1 V +1 11/20/25, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90352
-
Christian Kuhn commented on patch set 1 11/20/25, 18:58
-
Christian Kuhn commented on patch set 1 CR -1 11/20/25, 20:05
AsAllowedCallable.php:24Replyactually -1: i perceive readonly as a positive asset we should have whenever possible unless there is a good reason not to have it. -
Oliver Hader commented on patch set 1 11/21/25, 11:45
AsAllowedCallable.php:24ReplyThat's fine more me, since my muscle memory automatically uses `final readonly` for most new classes... :) -
Oliver Hader abandoned the change 11/21/25, 11:45
not required
AsAllowedCallable.php:24