Review main Abandoned

91783[TASK] Remove superfluous readonly declaration in AsAllowedCallable

Oliver Hader CR -1 V 0 Easy +1 −1 updated 11/21/25, 11:45

Commit message

Review

  • Code review CR -1
    • Christian Kuhn -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 11/20/25, 18:47

  2. core-ci voted on patch set 1 V +1 11/20/25, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90352

  3. Christian Kuhn commented on patch set 1 11/20/25, 18:58

    AsAllowedCallable.php:24

    why not just keep it?
  4. Christian Kuhn commented on patch set 1 CR -1 11/20/25, 20:05

    AsAllowedCallable.php:24 Reply

    actually -1: i perceive readonly as a positive asset we should have whenever possible unless there is a good reason not to have it.
  5. Oliver Hader commented on patch set 1 11/21/25, 11:45

    AsAllowedCallable.php:24 Reply

    That's fine more me, since my muscle memory automatically uses `final readonly` for most new classes... :)
  6. Oliver Hader abandoned the change 11/21/25, 11:45

    not required