Review main Merged

91785[TASK] Rename workspace module identifier

Oli Bartsch CR +2 V +2 Normal +41 −22 updated 11/21/25, 10:32

Commit message

This finishes #108230 by renaming the module
identifier to "workspaces_publish" and documenting
the changes accordingly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1520

  1. Oli Bartsch uploaded patch set 1 11/20/25, 20:48

  2. Christian Kuhn commented on patch set 1 CR -1 11/20/25, 21:03

    requires issue: this is far more than a 'typo-fix' follow-up.
  3. core-ci voted on patch set 1 V -1 11/20/25, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90373

  4. Oli Bartsch uploaded patch set 2 CR -1 V -1 11/20/25, 21:32

  5. Oli Bartsch updated the commit message in patch set 3 11/20/25, 21:34

  6. Oli Bartsch commented on patch set 3 11/20/25, 21:37

    Reply

    Sure, it’s more than just a typo fix. I marked it as a follow-up because it implements the requirement from the original issue, which explicitly stated that “the ID should be moved from workspaces_admin to content_publish.” Creating a new issue for the same requirement felt redundant. That said, this detail shouldn’t block the main change, so I’ve now created a separate issue for it.
  7. core-ci voted on patch set 2 V +1 11/20/25, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90395

  8. core-ci voted on patch set 3 V +1 11/20/25, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90396

  9. Oli Bartsch uploaded patch set 4 V +1 11/20/25, 23:14

  10. core-ci voted on patch set 4 V +1 11/20/25, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90415

  11. Benni Mack commented on patch set 4 11/21/25, 06:48

    what do you think of the module identifier "workspaces_publish"? This way, we don't bind it to the parent identifier
  12. Lina Wolf commented on patch set 4 11/21/25, 07:35

    Reply

    I like that, shall I do it?
  13. Lina Wolf commented on patch set 4 CR -1 11/21/25, 09:59

    Working on it
  14. Lina Wolf uploaded patch set 5 CR -1 V +1 11/21/25, 10:07

  15. Lina Wolf commented on patch set 5 11/21/25, 10:07

    Reply

    Done
  16. Lina Wolf voted on patch set 5 CR +1 V +1 11/21/25, 10:08

  17. core-ci voted on patch set 5 V +1 11/21/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90478

  18. Oli Bartsch commented on patch set 5 CR +1 V +1 11/21/25, 10:20

    Reply

    Thanks.
  19. Benni Mack voted on patch set 5 CR +2 V +2 11/21/25, 10:32

  20. Benni Mack merged patch set 6 11/21/25, 10:32