91785[TASK] Rename workspace module identifier
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Lina Wolf +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 15
- Build/Sources/TypeScript/workspaces/toolbar/workspaces-menu.ts+1 −1
- Build/Sources/TypeScript/workspaces/backend.ts+3 −3
- typo3/sysext/backend/Tests/Functional/Routing/UriBuilderTest.php+3 −3
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107628-ImprovedBackendModuleNamingAndStructure.rst+19 −1
- typo3/sysext/install/Classes/Updates/UserPermissionsForRenamedModulesMigration.php+1 −0
- typo3/sysext/workspaces/Classes/Backend/LiveSearch/WorkspaceProvider.php+2 −2
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+3 −3
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
- typo3/sysext/workspaces/Configuration/Backend/AjaxRoutes.php+1 −1
- typo3/sysext/workspaces/Configuration/Backend/Modules.php+2 −2
- typo3/sysext/workspaces/Resources/Private/Templates/Review/Index.fluid.html+1 −1
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/DropDown.fluid.html+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/toolbar/workspaces-menu.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 1520
-
Oli Bartsch uploaded patch set 1 11/20/25, 20:48
-
Christian Kuhn commented on patch set 1 CR -1 11/20/25, 21:03
requires issue: this is far more than a 'typo-fix' follow-up. -
core-ci voted on patch set 1 V -1 11/20/25, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90373
-
Oli Bartsch uploaded patch set 2
CR -1V -111/20/25, 21:32 -
Oli Bartsch updated the commit message in patch set 3 11/20/25, 21:34
-
Oli Bartsch commented on patch set 3 11/20/25, 21:37
Reply
Sure, it’s more than just a typo fix. I marked it as a follow-up because it implements the requirement from the original issue, which explicitly stated that “the ID should be moved from workspaces_admin to content_publish.” Creating a new issue for the same requirement felt redundant. That said, this detail shouldn’t block the main change, so I’ve now created a separate issue for it. -
core-ci voted on patch set 2 V +1 11/20/25, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90395
-
core-ci voted on patch set 3 V +1 11/20/25, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90396
-
Oli Bartsch uploaded patch set 4
V +111/20/25, 23:14 -
core-ci voted on patch set 4 V +1 11/20/25, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90415
-
Benni Mack commented on patch set 4 11/21/25, 06:48
what do you think of the module identifier "workspaces_publish"? This way, we don't bind it to the parent identifier -
Lina Wolf commented on patch set 4 11/21/25, 07:35
Reply
I like that, shall I do it? -
Lina Wolf commented on patch set 4 CR -1 11/21/25, 09:59
Working on it -
Lina Wolf uploaded patch set 5
CR -1V +111/21/25, 10:07 -
Lina Wolf commented on patch set 5 11/21/25, 10:07
Reply
Done -
Lina Wolf voted on patch set 5 CR +1 V +1 11/21/25, 10:08
-
core-ci voted on patch set 5 V +1 11/21/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90478
-
Oli Bartsch commented on patch set 5 CR +1 V +1 11/21/25, 10:20
Reply
Thanks. -
Benni Mack voted on patch set 5 CR +2 V +2 11/21/25, 10:32
-
Benni Mack merged patch set 6 11/21/25, 10:32