Review main Merged

91787[TASK] Replace remaining mentions of "annotation" with "attribute"

Elias Häußler CR +2 V +2 Easy +16 −16 updated 11/21/25, 10:56

Commit message

Annotations are no longer used in Extbase. This patch replaces all
remaining mentions of "annotation" with its successor "attribute".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 79

  1. Elias Häußler uploaded patch set 1 11/20/25, 21:10

  2. Elias Häußler uploaded patch set 2 11/20/25, 21:16

  3. core-ci voted on patch set 1 V +1 11/20/25, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90386

  4. core-ci voted on patch set 2 V +1 11/20/25, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90388

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/20/25, 21:51

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 11/20/25, 22:12

  7. Christian Kuhn merged patch set 3 11/20/25, 22:12

  8. Garvin Hicking commented on patch set 3 11/20/25, 23:49

    MixedSymfonyModel.php:21

    This was intentionally created to ensure the old annotations still work I think

    ValidatorResolverTest.php:128

    This was intentionally created to ensure the old annotations still work I think
  9. Elias Häußler commented on patch set 3 11/21/25, 10:56

    MixedSymfonyModel.php:21 Reply

    Talked to Garvin; this is actually okay to change. The related model that is used to test the behavior with the old annotation namespace is `AliasedModel`, so we still have this check in place.

    ValidatorResolverTest.php:128 Reply

    Done