91787[TASK] Replace remaining mentions of "annotation" with "attribute"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/extbase/Classes/Attribute/FileUpload.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+4 −4
- typo3/sysext/extbase/Classes/Mvc/Controller/FileUploadConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −1
- typo3/sysext/extbase/Classes/Service/FileHandlingService.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/MixedSymfonyModel.php2+1 −1
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php2+1 −1
- typo3/sysext/extbase/Tests/Unit/Attribute/FileUploadTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −1
Review log 79
-
Elias Häußler uploaded patch set 1 11/20/25, 21:10
-
Elias Häußler uploaded patch set 2 11/20/25, 21:16
-
core-ci voted on patch set 1 V +1 11/20/25, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90386
-
core-ci voted on patch set 2 V +1 11/20/25, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90388
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/20/25, 21:51
-
Christian Kuhn voted on patch set 2 CR +2 V +2 11/20/25, 22:12
-
Christian Kuhn merged patch set 3 11/20/25, 22:12
-
Garvin Hicking commented on patch set 3 11/20/25, 23:49
ValidatorResolverTest.php:128This was intentionally created to ensure the old annotations still work I think -
Elias Häußler commented on patch set 3 11/21/25, 10:56
MixedSymfonyModel.php:21ReplyTalked to Garvin; this is actually okay to change. The related model that is used to test the behavior with the old annotation namespace is `AliasedModel`, so we still have this check in place.ValidatorResolverTest.php:128ReplyDone
MixedSymfonyModel.php:21