Review main Merged

91789[BUGFIX] Remove check of php_tree_stop in PageRepository

Georg Ringer CR +2 V +2 Easy +17 −19 updated 12/22/25, 09:13

Commit message

The field `php_tree_stop` in the pages table is only used for the page
tree and must not change any behavior, especially not in the frontend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 11/20/25, 21:26

  2. Georg Ringer commented on patch set 1 11/20/25, 21:26

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/20/25, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90392

  4. Oliver Klee updated the commit message in patch set 2 V +1 11/20/25, 23:20

  5. core-ci voted on patch set 2 V +1 11/20/25, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90418

  6. Christian Kuhn commented on patch set 2 11/20/25, 23:47

    interesting. looks good at first glance and the code *seems* to be fe called only, but i'd be interested in digging a bit deeper to see how this ended up there to be sure.
  7. Benni Mack commented on patch set 2 11/21/25, 06:48

    Reply

    looking into this, a few things changed: - PageRepository is now also used in BE (not just FE) - PageRepository is not used in PageTree construction, due to performance and permission reasons IMHO this is very valid (99% safe), the only thing I would check is the label / naming / docs back from 2008 (4.x) and see if we changed the usages here.
  8. Oliver Klee rebased onto patch set 3 V +1 12/16/25, 19:32

  9. core-ci voted on patch set 3 V +1 12/16/25, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92312

  10. Benni Mack commented on patch set 3 CR +1 V +1 12/19/25, 09:02

    Reply

    I checked this, and we're good.
  11. Garvin Hicking voted on patch set 3 CR +1 V +1 12/19/25, 09:52

  12. Josef Glatz voted on patch set 3 V +1 12/20/25, 16:22

  13. Benni Mack voted on patch set 3 CR +2 V +2 12/22/25, 09:13

  14. Benni Mack merged patch set 4 12/22/25, 09:13