91790[TASK] Harmonize label positioning in element browser
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/Sass/component/_elementbrowser.scss+0 −26
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+4 −4
- typo3/sysext/backend/Classes/LinkHandler/AbstractLinkHandler.php+1 −1
- typo3/sysext/backend/Resources/Private/Layouts/LinkBrowser.fluid.html+5 −1
- typo3/sysext/backend/Resources/Private/Templates/LinkBrowser/Mail.fluid.html+6 −6
- typo3/sysext/backend/Resources/Private/Templates/LinkBrowser/Telephone.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/LinkBrowser/Url.fluid.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+0 −5
- typo3/sysext/filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+3 −3
Review log 3034
Show 69 earlier messages
-
Georg Ringer uploaded patch set 1 11/20/25, 21:34
-
Georg Ringer commented on patch set 1 11/20/25, 21:34
This change is ready for review. -
core-ci voted on patch set 1 V +1 11/20/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90397
-
Jasmina Ließmann uploaded patch set 2
V +111/21/25, 00:48 -
core-ci voted on patch set 2 V +1 11/21/25, 00:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90423
-
Jasmina Ließmann uploaded patch set 3
V +111/21/25, 00:57 -
core-ci voted on patch set 3 V +1 11/21/25, 01:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90424
-
Josef Glatz commented on patch set 3 CR +1 V +1 11/21/25, 08:45
It takes some getting used to. However, it adds value, and the UI changes (also the previous introduced rounded corners) make it intuitive. The order of the fields has also been improved which I like! Thanks for coming up with the idea to render label above fields! -
Oli Bartsch commented on patch set 3 11/21/25, 08:59
I like this approach. Especially because it's consistent with FormEngine. However, I suggest to not add any col-* classes. We try to avoid them if possible and in this case I think they are not required. They even lead to the fact, that when types do only contain one of the smaller fields, this looks kind of "broken" as all other fields are full width. Besides that, I like!
-
Jasmina Ließmann commented on patch set 3 11/21/25, 09:10
Reply
The two fields `target` and `class` are displayed side by side so that the modified label display (move from beside field to above the field) does not take up too much space in the wizard and the user can still easily see the page or content element selection below as before. Otherwise, these options would be less visible on smaller screens. (See patch set 1 for more information). In addition, the `target` field and, in most cases, the `class` field only contain options with little text (compared to the other fields), which do not justify a field size across the entire width. -
Oli Bartsch commented on patch set 3 11/21/25, 09:34
Reply
Oke, I can probably live with displaying the single class field for some types. However, I still wonder whether we should rely on these col-X and col-sm-X classes. As far as I know - and I'm not deeply involved in current templating - these contextless utility classes should ideally be avoided. -
Josef Glatz commented on patch set 3 11/21/25, 12:30
Reply
I understand that there might be plans to simplify css classes. But what can be the alternative to the `col-<breakpoint>-X col-X` classes which are widely known in mobile-first responsive web universe? -
Jasmina Ließmann commented on patch set 3 11/21/25, 17:19
Reply
The `col-X` classes are currently used in several places in the backend. I would keep them in the link browser for now and replace them with a custom class at a later time if necessary. Is that ok for you @bo@cedev.de? -
Oli Bartsch commented on patch set 3 CR +1 V +1 11/21/25, 18:02
Reply
Acknowledged -
Christian Kuhn voted on patch set 3 CR +1 V +1 11/21/25, 19:24
-
Jasmina Ließmann rebased onto patch set 4
CR +1V +111/22/25, 15:30 -
core-ci voted on patch set 4 V +1 11/22/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90652
-
Christian Kuhn voted on patch set 4 CR +1 V +1 11/22/25, 15:40
-
Jasmina Ließmann voted on patch set 4 CR +2 V +2 11/22/25, 15:40
-
Jasmina Ließmann merged patch set 5 11/22/25, 15:40
-
Benjamin Kott commented on patch set 5 11/22/25, 15:47
post -1 this is completly contrary to the way we are currently moving, we are removing all col and rows from the system in the effort to get rid of them. introducing them here again is actually a step back. we had scoped css that we could modify. -
Benjamin Kott commented on patch set 5 11/22/25, 15:50
please see regarding formengine. 91805: [TASK] Replace Bootstrap grid with CSS Grid in FormEngine field groups | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91805 -
Josef Glatz commented on patch set 5 11/22/25, 16:01
Reply
We discussed it and your mentioned issue and patch is 6 hours old. What about adding adoptions in your patch which changes it to the new grid system? -
Benjamin Kott commented on patch set 5 11/22/25, 16:15
Reply
It was just an example that we are going to get rid of it - even in the form engine, the point is, the element browser had scoped CSS as intended so we can modify the other usages without interfering. this is why it was built that way. that is now removed. There was no need to adjust it right now. It was designed to handle all kinds of inputs as this is Extensible and can have custom implementations, so we decided to go that route back then. Because it also allowed to have single input without wasting a lot of whitespace. -
Benjamin Kott commented on patch set 5 11/22/25, 16:15
Reply
the best way to fix it, to revert the patch and leave it as is. because the display and positioning was intended. -
Christian Kuhn commented on patch set 5 11/22/25, 16:17
Reply
-2 to revert.Reply
this has been discussed above, see the comments. the change is a ux improvement, there is no suitable alternative right now, nobody can look into your head, your wip-solution is 6 hours old in a 3 year ongoing "but i want to get rid of bootstrap" journey. ack --type=html 'col-[0-9].' | wc -l 27 ack --type=html 'col-sm' | wc -l 38 ack --type=html 'col"' | wc -l 48 ack --type=html 'class="row"' | wc -l 47 please go ahead and finish those 160 cases and document suitable replacements, use cases and solutions for everybody to understand and refer to. -
Benjamin Kott commented on patch set 5 11/22/25, 16:19
Reply
i mean, check the telephone or email part - it now looks just broken. -
Christian Kuhn commented on patch set 5 11/22/25, 16:20
Reply
i'm sure you'll be able to change this one place again together with the 160 other cases if you manage to finish your patch. there is no point in reverting this now. -
Benjamin Kott commented on patch set 5 11/22/25, 16:24
Reply
this is an ongoing effort; all mergers are informed about this. we discussed this multiple times in the past - also places where we accept that we currently have no better implementations available. this was a perfectly suitable implementation that removed now. this is nothing in my head, it was like that before and was rewritten. see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78154 -
Benjamin Kott commented on patch set 5 11/22/25, 16:29
Reply
yes, that was one of the places i already cleaned up. -
Christian Kuhn commented on patch set 5 11/22/25, 16:35
Reply
in this case patch authors and reviewers decided it is good to improve the view with this patch now instead of waiting further indefinite time. please go ahead and finish started grid works, this little detail shouldn't block you, does it? -
Christian Kuhn commented on patch set 5 11/22/25, 17:24
Reply
the issue has been reported as 'styling problem'. it is better now. i'll not block a revert if you insist on it. i'm trying to actively manage, steer and finish work, and to keep contributors happy and delivering continuous streams of improvements. this one is an improvement to me and i voted accordingly. -
Benjamin Kott commented on patch set 5 11/22/25, 17:37
Reply
of course, it does. because i need to fix something that did not need fixing - because the fix is to revert it to it´s old state.Reply
i´ll leave the patch for the issue here it also needs to be backported to 13.4 91821: [BUGFIX] Correct label rendering in element browser | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91821 -
Benjamin Kott wrote 11/23/25, 10:51
Created a revert of this change as I367c16807f6f70aa9ef4c2f37b2932c8ee0e625e