Review main Merged

91796[TASK] Add single submodule promotion

Oli Bartsch CR +2 V +2 Normal +234 −0 updated 11/21/25, 15:48

Commit message

Adds a internal appearance option for top-level modules
that automatically promotes a single submodule to
standalone status.

When a parent module has only one submodule and this
option is enabled, the submodule becomes a standalone
top-level module (like dashboard), inheriting the
parent's navigation component, position, and aliases.

This is applied to the "media" module, so when
"media_management" is the only submodule, like in
99% of all installations, it appears as a standalone
module in the menu.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1415

  1. Oli Bartsch uploaded patch set 1 11/20/25, 23:58

  2. core-ci voted on patch set 1 V +1 11/21/25, 00:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90421

  3. Jasmina Ließmann commented on patch set 1 11/21/25, 01:03

  4. Oli Bartsch commented on patch set 1 11/21/25, 01:04

    Reply

    This is a different approach.
  5. Oli Bartsch commented on patch set 1 11/21/25, 01:08

    Reply

    this actually promotes the sub module instead of making a top level module clickable, which is not following the API. This approach is in line with the api and does not need any change to the e.g. templates or other component.
  6. Georg Ringer commented on patch set 1 11/21/25, 04:57

    I kind of like it but on the other hand the module "media" now looks being part of "content" and this is not good for the editors (i guess). I provided an alternative approach in forge issue which adds the parents's name to the label
  7. Lina Wolf commented on patch set 1 11/21/25, 06:49

    Reply

    In that case it does no harm, media IS content...
  8. Lina Wolf commented on patch set 1 11/21/25, 06:52

    How about we make a fallback parent module where an item is moved if it would be alone in its parent? This way integrators and developers could still define the desired behaviour than. Content should be fine for media as it is a content. If I desire, however I would still like to display my single module in its own section to promote it or something like that
  9. Oli Bartsch commented on patch set 1 11/21/25, 10:09

    Reply

    Technically and visually this is already separated. I think this might can get improved visually, but suits the technical use case for now.

    Reply

    Done

    Reply

    TBH I don't think that we have uses cases for this currently. Media is really the only one. Thats why I made this an internal option for this single use case - for now.
  10. Georg Ringer voted on patch set 1 CR +1 V +1 11/21/25, 10:16

  11. Lina Wolf commented on patch set 1 11/21/25, 10:20

    Reply

    The slightly larger wspace looks more like an error then a real visual divider to me...

    Reply

    It can happen to any top level module, including third party ones, depending on user permissions
  12. Oli Bartsch commented on patch set 1 11/21/25, 10:31

    Reply

    I understand. But as said, this is the current state of how "standalone" modules are displayed. We'll improve this for LTS anyways, since we need to find a solution for the third level modules.
  13. Lina Wolf commented on patch set 1 11/21/25, 10:43

    Reply

    Not blocking it but I see no improvement with the status Quo
  14. Benni Mack voted on patch set 1 CR +2 V +2 11/21/25, 15:48

  15. Benni Mack merged patch set 2 11/21/25, 15:48