91824[TASK] runTests.sh: Add command to run GUI in the browser
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Sven Liebert +1
-
Verified V +2 Done
- Stefan Bürk +2
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 4
Review log 3141
Show 1116 earlier messages
-
Jochen Roth uploaded patch set 1 11/22/25, 22:02
-
Jochen Roth uploaded patch set 2 11/22/25, 22:03
-
core-ci voted on patch set 1 V +1 11/22/25, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90697
-
core-ci voted on patch set 2 V +1 11/22/25, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90698
-
Jochen Roth uploaded patch set 3
V +111/22/25, 22:16 -
Stefan Bürk commented on patch set 3 11/22/25, 22:25
Question: Is it possible to recycle the `-g` flag for the playwright things the same way as for codeception tests instead of creating a additional testsuite internal setting other options ? Adjusting the help test to state the difference selium/thing in browser for playwright would be needed in that case. -
core-ci voted on patch set 3 V +1 11/22/25, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90703
-
Christian Kuhn commented on patch set 3 11/22/25, 23:42
*like* 'o' does not yet work for me, need to investigate. direct url in browser works. but i like local npm isn't required this way anymore, if i understand correctly.runTests.sh:528note e2e-prepare is missing here, should be removed from e2e explanation and should receive an own entry here. i think we could just do this along the way. -
Christian Kuhn commented on patch set 3 11/22/25, 23:44
Reply
well, it's kinda different than -g since it gives way more than just "look at browser doing things", but a full ui to run and check stuff. i could live well with having it a dedicated 'suite'. -
Jochen Roth uploaded patch set 4
V +111/23/25, 02:13 -
core-ci voted on patch set 4 V +1 11/23/25, 02:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90716
-
Sven Liebert commented on patch set 4 CR +1 V +1 11/23/25, 13:02
Works for me and like it! -
Jochen Roth uploaded patch set 5
CR +1V +111/23/25, 13:21 -
Sven Liebert voted on patch set 5 CR +1 V +1 11/23/25, 13:26
-
core-ci voted on patch set 5 V +1 11/23/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90747
-
Stefan Bürk commented on patch set 5 11/23/25, 13:34
runTests.sh:252```suggestion PLAYWRIGHT_GUI_PORT=${PLAYWRIGHT_GUI_PORT:-43837} ``` Let's make setable from the outside. Granted, that port is most likly conflict free - but you may want eventually to have that started from 2 core checkouts (in the future) and using different ports for the different checkouts (core versions?). Does that make sense ? I guess so. With suggested edit it should be possible to use: ``` PLAYWRIGHT_GUI_PORT=109999 Build/Scripts/runTests.sh -s e2e-browser ``` TBH not tested (yet). What do you think ?runTests.sh:528ReplyI'd say we should add examples to the generic command exaples at the end of the helptext for the e2e* commands.
-
Christian Kuhn commented on patch set 5 11/23/25, 14:00
runTests.sh:528Replyi kinda dislike the help mess at the end: it is a random ball of random examples. it always hurts me when more randomness is added ^^ -
Christian Kuhn commented on patch set 5 11/23/25, 14:02
runTests.sh:528Reply(not saying no, but saying that this lengthy mess cripples overview and i always have to scroll up to see the true list of things). -
Christian Kuhn commented on patch set 5 11/23/25, 14:05
runTests.sh:528Replyso we can of course just add more now, but we may also want to think about some better and more future proof solution - runTests evolved heavily over the years with more and more stuff in it, maybe it is time to reconsider for instance the help view? unsure what exactly to do, which is why i'm only naming it for now, without a thought through solution at hand. -
Christian Kuhn commented on patch set 5 11/23/25, 14:06
runTests.sh:528Replyof course not with *this* patch. just saying this could be a topic. -
Stefan Bürk commented on patch set 5 11/23/25, 14:37
runTests.sh:528ReplyGood point. And you are right. Maybe something like "option overview" and "extended help with examples" or similar other structures. -
Jochen Roth marked it work in progress 11/23/25, 14:47
-
Jochen Roth commented on patch set 5 11/23/25, 14:52
This change is ready for review.For informations sake, trying to fix the "database is locked" issue and make the tests reliable. And looks like apache drops connections at some point which needs fixing as well. -
Jochen Roth marked it work in progress 11/23/25, 14:52
-
Jochen Roth uploaded patch set 6
CR +1V +111/23/25, 20:59 -
core-ci voted on patch set 6 V +1 11/23/25, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90769
-
Jochen Roth uploaded patch set 7
V +111/23/25, 22:18 -
Jochen Roth marked it ready for review 11/23/25, 22:18
-
core-ci voted on patch set 7 V +1 11/23/25, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90775
-
Jochen Roth uploaded patch set 8
V +111/23/25, 22:26 -
Jochen Roth uploaded patch set 9 11/23/25, 22:29
-
core-ci voted on patch set 8 V +1 11/23/25, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90776
-
core-ci voted on patch set 9 V +1 11/23/25, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90777
-
Stefan Bürk commented on patch set 9 11/24/25, 13:20
runTests.sh:252ReplyTalked about that, understand this now. This is for the container port which is determined dynamically. Closing the case. -
Stefan Bürk commented on patch set 9 11/24/25, 13:21
Reply
This was a misssunderstanding from my side. Closing the case.runTests.sh:528ReplyDone -
Jochen Roth rebased onto patch set 10
V +111/24/25, 13:33 -
core-ci voted on patch set 10 V +1 11/24/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90842
-
Stefan Bürk voted on patch set 10 CR +1 V +1 11/24/25, 13:54
-
Sven Liebert commented on patch set 10 CR +1 V +1 11/24/25, 14:11
LGTM -
Stefan Bürk voted on patch set 10 CR +2 V +2 11/24/25, 15:05
-
Stefan Bürk merged patch set 11 11/24/25, 15:05