91828[BUGFIX] Define setting `offlineMode` in composer view of Extension Manager
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Stefan Bürk +1
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Stefan Bürk +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Georg Ringer uploaded patch set 1 11/23/25, 06:44
-
Georg Ringer commented on patch set 1 11/23/25, 06:44
This change is ready for review. -
core-ci voted on patch set 1 V +1 11/23/25, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90727
-
Oliver Klee updated the commit message in patch set 2
V +111/23/25, 08:53 -
core-ci voted on patch set 2 V +1 11/23/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90732
-
Simon Schaufelberger commented on patch set 2 11/23/25, 10:33
ExtensionComposerStatusController.php:50I've learned from lolly that it's also possible to inject the offline mode setting directly. Don't have an example at hand but can check in the evening if needed. -
Stefan Bürk commented on patch set 2 11/23/25, 14:45
ExtensionComposerStatusController.php:50ReplyYou mean: ``` #[Autowire(expression: 'service("extension-configuration").get("extensionmanager", "offlineMode")')] protected bool $offlineMode = false, ``` 87575: [TASK] Add DI alias for ExtensionConfiguration | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87575 -
Georg Ringer commented on patch set 2 11/23/25, 15:16
in the long run, this should be moved to real submodules and having the check in the submodule definition itself. however to have this also fixable in 13.4 and to have it easy to review, I want to just use the same code as in the other controller. -
Stefan Bürk commented on patch set 2 CR +1 V +1 11/24/25, 19:03
ExtensionComposerStatusController.php:50ReplyWe keep the current due to backport. Refactoring is needed anyways. -
Sven Liebert voted on patch set 2 CR +1 V +1 11/24/25, 19:05
-
Simon Schaufelberger commented on patch set 2 11/24/25, 19:49
ExtensionComposerStatusController.php:50Reply UnresolvedThis feature is also available in TYPO3 13 so backport will be possible also with DI. -
Josef Glatz voted on patch set 2 CR +1 V +1 12/10/25, 04:54
-
Georg Ringer voted on patch set 2 CR +2 V +2 12/29/25, 16:50
-
Georg Ringer merged patch set 3 12/29/25, 17:19