Review main Merged

91832Revert "[TASK] Harmonize label positioning in element browser"

Benjamin Kott CR +2 V +2 Normal +49 −22 updated 11/25/25, 11:48

Commit message

This reverts commit 018a9f761721b20690a0589b5da350223c146937.

Reason for revert:

This patch (91790) unintentionally moves the element browser layout
backwards in terms of the architecture we are actively building. It
reintroduces static Bootstrap column classes that we are systematically
removing, and it reduces the available space for essential information.
For example, email fields may become truncated, and users are forced to
scroll to reach the “Set” button. In several element browser views, the
new layout also creates excessive unused whitespace.

The previous solution was deliberately designed to accommodate the space
requirements of the element browser and used dedicated markup because
this view has different needs than other form areas. The patch removed
that specialization, but without actually resolving the underlying issue
it was meant to address.

The original problem is a side effect of the form styling rebuild
introduced in v13. Therefore, any real fix must also be backported to
TYPO3 v13. Patch 91790 does not resolve the issue for current users.

A minimal, targeted replacement patch (91821) has been created to
correctly address the label-rendering problem. It fixes the broken
ellipsis on form labels, restores the intended layout, and increases
the available label space, especially important for languages like
German, while remaining fully compatible with both v13 and main.

We are therefore reverting 91790 in favor of 91821.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 810

  1. Benjamin Kott uploaded patch set 1 11/23/25, 10:51

  2. Benjamin Kott rebased onto patch set 2 11/23/25, 10:56

  3. Benjamin Kott commented on patch set 2 11/23/25, 10:59

    once merged, the following patch will be applied to resolve the initial issue. 91821: [BUGFIX] Correct label rendering in element browser | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91821
  4. core-ci voted on patch set 1 V +1 11/23/25, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90736

  5. core-ci voted on patch set 2 V +1 11/23/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90738

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 11/23/25, 17:05

  7. Josef Glatz voted on patch set 2 CR +1 V +1 11/24/25, 04:09

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 11/24/25, 06:45

  9. Benjamin Kott merged patch set 3 11/24/25, 06:45

  10. Christian Kuhn wrote 11/25/25, 11:48

    Removed reviewer Christian Kuhn.