Review main Merged Breaking

91835[!!!][TASK] Remove superfluous CacheHashCalculator public methods

Oliver Hader CR +2 V +2 Normal +92 −38 updated 11/23/25, 14:01

Commit message

- removed CacheHashCalculator::setConfiguration()
- removed CacheHashConfiguration::with()

Both methods were only used for testing purposes.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Oliver Hader uploaded patch set 1 11/23/25, 13:00

  2. core-ci voted on patch set 1 V +1 11/23/25, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90745

  3. Oliver Hader uploaded patch set 2 V +1 11/23/25, 13:25

  4. Oliver Hader commented on patch set 2 11/23/25, 13:27

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 11/23/25, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90748

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 11/23/25, 13:48

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 11/23/25, 14:00

  8. Oliver Hader commented on patch set 2 11/23/25, 14:01

    Thx ❤️
  9. Oliver Hader voted on patch set 2 CR +2 V +2 11/23/25, 14:01

  10. Oliver Hader merged patch set 3 11/23/25, 14:01