Review main Merged

91839[BUGFIX] Boot non-failsafe state in `cache:flushtags` command

Stefan Bürk CR +2 V +2 Normal +58 −5 updated 11/23/25, 18:39

Commit message

With #104054 the `cache:flushtags` command has been introduced
to allow flushing cache(s) based on one or more tags.

The command is registered in `EXT:core` using `ServiceProvider`,
making the command available in failsafe context simply using
the cache manager, which has most of the caches configured as
`NullBackend` (aka install tool context) and not the real cache
configuration, which means that tags are not really removed.

This change modifes the command to recieve the bootservice
instead of the cache manager, booting up the non-failesafe
mode and grapping the CacheManager from non-failsafe mode,
having the real configuration for all caches in place.

To cover what has been missed with the original implementation
the `CacheFlushTagsCommandTest` functional test is added, which
already states the broken state before the included change and
demonstrating it is now possible to remove tags correctly for
example from the page cache.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 68

  1. Stefan Bürk uploaded patch set 1 11/23/25, 16:00

  2. Stefan Bürk updated the commit message in patch set 2 11/23/25, 16:04

  3. core-ci voted on patch set 1 V +1 11/23/25, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90757

  4. core-ci voted on patch set 2 V +1 11/23/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90759

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/23/25, 16:51

  6. Sven Liebert voted on patch set 2 CR +1 V +1 11/23/25, 18:34

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 11/23/25, 18:39

  8. Stefan Bürk merged patch set 3 11/23/25, 18:39