91840[TASK] Change infobox title for status in setup module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1517
-
Oli Bartsch uploaded patch set 1 11/23/25, 20:56
-
core-ci voted on patch set 1 V +1 11/23/25, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90768
-
Jasmina Ließmann commented on patch set 1 11/23/25, 21:06
A note from me: I specifically chose "Note" over "Info" as the state because the gray color is more subtle and less noticeable. If no pages with site configuration are present, corresponding infoboxes appear in blue color ("Info" state). If the initial infobox were also blue, it would have the same level of importance, which I don't think is appropriate. The initial infobox contains general information, while the other infoboxes offer recommendations for the user. -
Oli Bartsch commented on patch set 1 11/23/25, 21:10
Reply
Okay, but having the infobox title set to "Information" while using the Notice state does not match in my opinion. -
Oli Bartsch commented on patch set 1 11/23/25, 21:15
Reply
Additionally, I would argue that this infobox is shown all the time while the "no pages with site config" will basically almost never be shown in real instances I guess. -
Jasmina Ließmann commented on patch set 1 11/23/25, 21:17
Reply
Perhaps we can find a better title in that case, or we can present the information as introtext (as, for example, in "Status Report" or the "TypoScript" submodules)? If okay for you, I'd like to postpone this decision and see how the current implementation feels in the near future. Then it can always be changed later. -
Oli Bartsch commented on patch set 1 11/23/25, 21:29
Reply
I would prefer that we settle this now rather than postpone it. Once we move on to the next set of topics (which we have lot before LTS), this detail will realistically never be revisited, and I don’t see a strong reason to delay the decision. Regarding the idea of changing the title or moving the text into an intro section. I don't see how th given examples fit this pattern, since those modules don’t use such introtext (with dynamic values). For me, the combination of title and state should be consistent and clear right away. If we can agree on a matching title/state pair now, we can close this point and focus fully on the upcoming work. -
Oli Bartsch commented on patch set 1 11/23/25, 21:34
Reply
This is really such a small detail, we should not put our energy in. While I still think info state would be the correct one, I would also be fine, if we change just the title to match the state. But please let's resolve this now. -
Garvin Hicking commented on patch set 1 11/23/25, 21:54
Reply
My 2 cents: I would prefer the "notice" layout and change the title -
Jasmina Ließmann commented on patch set 1 11/23/25, 22:10
Reply
Changing title is fine for me. -
Oli Bartsch uploaded patch set 2
V +111/24/25, 08:25 -
Oli Bartsch commented on patch set 2 11/24/25, 08:26
Reply
Done -
core-ci voted on patch set 2 V +1 11/24/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90801
-
Garvin Hicking commented on patch set 2 CR +1 V +1 11/24/25, 08:36
works for me, thanks -
Jasmina Ließmann voted on patch set 2 CR +1 V +1 11/24/25, 08:57
-
Oli Bartsch voted on patch set 2 CR +2 V +2 11/24/25, 09:05
-
Oli Bartsch merged patch set 3 11/24/25, 09:05