91843[TASK] Avoid invalid dropdown button in module menu processing
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Markus Klein +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Markus Klein +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1724
-
Garvin Hicking uploaded patch set 1 11/24/25, 08:24
-
Markus Klein voted on patch set 1 CR +1 V +1 11/24/25, 08:26
-
Markus Klein commented on patch set 1 11/24/25, 08:26
-
core-ci voted on patch set 1 V +1 11/24/25, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90799
-
Oli Bartsch commented on patch set 1 11/24/25, 08:39
```suggestion This was fine in v12+v13, but breaks in v14 because no ```DocHeaderComponent.php:477ReplyYes please, $label can only be string and we should therefore use strict comparison.DocHeaderComponent.php:478The underlying reason is this: Previously, the menu was rendered as a <select>, so the first <option> was shown automatically and there was no separate "label" for the menu itself. That implicit behavior is what changed. I would like this to be described more clearly, because right now it is not obvious what exactly changed or why. Also, it still looks as if this could fail when non of the. menuItems got a title, but the title is actually mandatory for them. -
Garvin Hicking uploaded patch set 2
CR +1V +111/24/25, 08:45 -
Garvin Hicking commented on patch set 2 11/24/25, 08:45
Reply
DoneDocHeaderComponent.php:477ReplyDoneDocHeaderComponent.php:478ReplyDone -
core-ci voted on patch set 2 V -1 11/24/25, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90803
-
Oli Bartsch commented on patch set 2 11/24/25, 10:19
DocHeaderComponent.php:495AFAICS this replaces any set label now. And this is not needed at all. menuItem->getTitle() must return a non empty string, otherwise it would not be part of the getMenuItems() and we have at least 2 valid items at this point, see early return in line 467. -
core-ci commented on patch set 2 11/24/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90803
-
Garvin Hicking commented on patch set 3
V -111/24/25, 11:13Published edit on patch set 2. -
Garvin Hicking commented on patch set 4 11/24/25, 11:14
Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 11/24/25, 11:15
DocHeaderComponent.php:495ReplyYes. Don't know why I did that. Brain still not working. :-( -
core-ci voted on patch set 3 V +1 11/24/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90820
-
core-ci voted on patch set 4 V +1 11/24/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90821
-
Oli Bartsch uploaded patch set 5
V +111/24/25, 11:59 -
Oli Bartsch commented on patch set 5 CR +1 V +1 11/24/25, 12:00
DocHeaderComponent.php:495ReplyDone -
Oli Bartsch updated the commit message in patch set 6
CR +1V +111/24/25, 12:02 -
Oli Bartsch voted on patch set 6 CR +1 V +1 11/24/25, 12:02
-
core-ci voted on patch set 5 V +1 11/24/25, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90827
-
core-ci voted on patch set 6 V +1 11/24/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90828
-
Markus Klein voted on patch set 6 CR +1 V +1 11/24/25, 14:33
-
Garvin Hicking voted on patch set 6 CR +2 V +2 11/24/25, 14:34
-
Garvin Hicking merged patch set 7 11/24/25, 14:34
DocHeaderComponent.php:477