Review main Merged

91844[BUGFIX] Fix performance regression in page language context

Benjamin Franzke CR +2 V +2 Easy +4 −0 updated 11/24/25, 12:50

Commit message

Ensure that the translation retrieval only tries to load
actual translations when fetching possible translations for
pages, otherwise the case where translations for the virtual
page uid=0 are retrieved, results in *all* `sys_language_uid=0`
pages being fetched, which can be a very large set
of pages, depending of the installation.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 11/24/25, 08:28

  2. core-ci voted on patch set 1 V +1 11/24/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90802

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 11/24/25, 09:39

  4. core-ci voted on patch set 2 V +1 11/24/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90810

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 11/24/25, 10:12

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/24/25, 11:07

  7. Oliver Klee voted on patch set 2 CR +1 11/24/25, 11:19

  8. Oli Bartsch commented on patch set 2 11/24/25, 11:51

    How can this be a _regression_ when the related patch just introduced this "page language context"? Should it maybe be "due to"?
  9. Benjamin Franzke commented on patch set 2 11/24/25, 12:38

    Reply

    The performance regression is in page language context retrieval. So I'm not talking about the general performance decrease that was caused (which you fix with you more general patch, which is fine as well), but about the detailed regression that slows down to multi-seconds loads when you have >100.000 pages. For me both wordings work. Fine with you?
  10. Benjamin Kott commented on patch set 2 11/24/25, 12:49

    Reply

    I think the wording regression is correct here, we can talk about is we usually phrase it that way. But it made it worse than before from that point regression is a fitting description.
  11. Benjamin Kott commented on patch set 2 CR +2 V +2 11/24/25, 12:50

    Reply

    I will resolve this comment, as its only about the wording of regression or not and not related to the code. I think it´s fine and will not have any negative effects.
  12. Benjamin Kott merged patch set 3 11/24/25, 12:50