Review 12.4 Merged

91855[TASK] Upgrade rollup and webpack with known vulnerabilities

Oliver Hader CR +2 V +2 Nightmare +1424 −1196 updated 11/24/25, 16:30

Commit message

Executed commands:
cd Build
nvm use
npm ci
npm audit fix
npm run build

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 363

Show 343 more files

Review log 810

  1. Oliver Hader uploaded patch set 1 11/24/25, 13:21

  2. core-ci voted on patch set 1 V -1 11/24/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90841

  3. Oliver Hader rebased onto patch set 2 V -1 11/24/25, 14:18

  4. core-ci voted on patch set 2 V +1 11/24/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90848

  5. Oliver Hader commented on patch set 2 11/24/25, 15:21

    I did not spot functional changes in the compiled sources. The changes stem from: * Arrow function parentheses removal: - Old: .map((t=>{...})) or .forEach((e=>{...})) - New: .map(t=>{...}) or .forEach(e=>{...}) - Change: Removed unnecessary parentheses around single-parameter arrow functions * Arrow function parentheses removal (no parameters): - Old: .addEventListener("click",(()=>{...})) - New: .addEventListener("click",()=>{...}) - Change: Removed outer parentheses wrapping arrow functions when used as arguments * Variable renaming consistency: Some minified variable names shuffled (e.g., r ↔ n, t ↔ r) but this is just minifier reordering, not functional changes
  6. Sven Liebert voted on patch set 2 CR +1 V +1 11/24/25, 15:32

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 11/24/25, 15:50

  8. Oliver Hader commented on patch set 2 11/24/25, 16:26

    Reply

    Done
  9. Oliver Hader voted on patch set 2 CR +2 V +2 11/24/25, 16:30

  10. Oliver Hader merged patch set 3 11/24/25, 16:30