91856[!!!][TASK] Require composer.json in classic mode
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Markus Klein +1
- Garvin Hicking +1
- Helmut Hummel +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Markus Klein +1
- Garvin Hicking +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 4
Review log 4553
Show 2128 earlier messages
-
Benni Mack uploaded patch set 1 11/24/25, 14:28
-
core-ci voted on patch set 1 V -1 11/24/25, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90849
-
Mathias Brodala commented on patch set 1 11/24/25, 14:45
> Classic Mode This makes this change easier to discover. -
Benni Mack commented on patch set 2
V -111/24/25, 15:10Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 11/24/25, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90855
-
Helmut Hummel uploaded patch set 3
V -111/25/25, 09:34 -
Helmut Hummel uploaded patch set 4 11/25/25, 09:36
-
core-ci voted on patch set 3 V -1 11/25/25, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90930
-
core-ci voted on patch set 4 V -1 11/25/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90931
-
Lina Wolf commented on patch set 4 11/25/25, 09:51
To state the obvious, we need a changelog entry . I would suggest to put this to WIP until it is ready for review -
Helmut Hummel uploaded patch set 5
V -111/25/25, 10:06 -
core-ci voted on patch set 5 V -1 11/25/25, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90933
-
Benni Mack commented on patch set 5 11/25/25, 11:32
Reply
Done -
Benni Mack uploaded patch set 6
V -111/25/25, 11:33 -
Benni Mack uploaded patch set 7 11/25/25, 11:39
-
core-ci voted on patch set 6 V +1 11/25/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90939
-
Garvin Hicking voted on patch set 7 CR +1 V +1 11/25/25, 11:43
-
Georg Ringer voted on patch set 7 CR +1 V +1 11/25/25, 11:47
-
Christian Kuhn voted on patch set 7 CR +1 V +1 11/25/25, 11:50
-
core-ci voted on patch set 7 V +1 11/25/25, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90940
-
Mathias Brodala commented on patch set 7 11/25/25, 11:50
Dropping the ones in TYPO3 itself will be done separately? -
Helmut Hummel commented on patch set 7 11/25/25, 11:52
Reply
What do you mean? -
Christian Kuhn commented on patch set 7 CR +2 V +2 11/25/25, 11:52
got a 'please merge' from benni since he is busy. i think this is a bit risky at this point in time, but it looks good from reading and playing around a bit. i'm going to merge this now. -
Mathias Brodala commented on patch set 7 11/25/25, 11:53
Reply
I mean typo3/*/ext_emconf.php which are obsolete now unless I misunderstand this change. -
Helmut Hummel commented on patch set 7 CR -2 11/25/25, 11:55
on it -
Christian Kuhn commented on patch set 7 CR +1 V +1 11/25/25, 11:55
helmut still on it. -
Kevin Appelt commented on patch set 7 11/25/25, 11:55
Reply
There are some minor places left, where we still check for ext_emconf.php so I guess we need to remove these places first before completely dropping the files. -
Helmut Hummel commented on patch set 7 11/25/25, 11:56
Reply
regarding dependency ordering they are unfortunately not obsolete. that will be handled in 14.1
-
Mathias Brodala commented on patch set 7 11/25/25, 11:57
Reply
Thanks for clarification, both of you. 👍 -
Helmut Hummel uploaded patch set 8 11/25/25, 11:58
Copied Votes: * Code-Review-2 (copy condition: "**changekind:NO_CHANGE** OR **is:MIN**") * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Helmut Hummel voted on patch set 8 CR 0 11/25/25, 11:59
-
Helmut Hummel voted on patch set 8 CR +1 V +1 11/25/25, 12:01
-
Markus Klein commented on patch set 7 CR +1 11/25/25, 12:01
Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 8 (copy condition: "changekind:NO_CHANGE OR is:MIN"). -
Markus Klein voted on patch set 8 CR +1 11/25/25, 12:02
-
Lina Wolf commented on patch set 8 11/25/25, 12:03
"Check for broken extensions" does not seem to detect such extensions and they are still displayed in the Extension Manager? -
Helmut Hummel commented on patch set 8 11/25/25, 12:04
Reply
@112@linawolf.de can it be that the extension was active? then yes. that is unfortunately true. maybe we can fix this later? -
Lina Wolf commented on patch set 8 11/25/25, 12:05
Reply
Acknowledged -
Christian Kuhn commented on patch set 8 CR +1 V +1 11/25/25, 12:06
Reply
that's not directly related since 'broken extensions' currently checks for ext_localconf / ext_tables only. i think we could fine-tune this after 14.0 if needed. is this ok with you? -
Christian Kuhn commented on patch set 8 11/25/25, 12:06
Reply
Done -
core-ci voted on patch set 8 V +1 11/25/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90943
-
Simon Schaufelberger commented on patch set 8 11/25/25, 12:09
Breaking-108310-RequireComposerJsonInClassicMode.rst:51to be very precise, extension_name is not correct as the extension name is written in UpperCamelCase while the extension key with snake_case. -
Markus Klein commented on patch set 8 V +1 11/25/25, 12:09
"works on my machine" -
Markus Klein commented on patch set 8 11/25/25, 12:11
Breaking-108310-RequireComposerJsonInClassicMode.rst:51Replywell, https://review.typo3.org/c/Packages/TYPO3.CMS/+/91856/8/typo3/sysext/core/Classes/Package/PackageManager.php#357 is wrong then too, because there we call it "package key", where we actually have the extensionKey there too. -
Garvin Hicking voted on patch set 8 CR +1 V +1 11/25/25, 12:13
-
Christian Kuhn commented on patch set 8 11/25/25, 12:15
Breaking-108310-RequireComposerJsonInClassicMode.rst:51Replyi hope it is ok to request sorting this out in a minor change or as drive-by later if really needed. -
Simon Schaufelberger commented on patch set 8 11/25/25, 12:15
Breaking-108310-RequireComposerJsonInClassicMode.rst:51Replyyeah, package key is also misleading as this would be "vendor/package-key" imo. -
Christian Kuhn voted on patch set 8 CR +2 V +2 11/25/25, 12:15
-
Christian Kuhn commented on patch set 8 11/25/25, 12:15
Breaking-108310-RequireComposerJsonInClassicMode.rst:51ReplyAcknowledged -
Christian Kuhn merged patch set 9 11/25/25, 12:16
-
Stefan Bürk voted on patch set 8 CR +1 V +1 11/25/25, 12:16
-
Lina Wolf commented on patch set 9 11/30/25, 05:34
Reply
I added an issue for this: https://forge.typo3.org/issues/108364 -
Lina Wolf commented on patch set 9 11/30/25, 05:39
We should have a look at what will happen if you upgrade Classic installations with active extensions that have no composer.json, at least when I was testing applying this change to an installation that had an active extension without composer.json no error message was displayed: https://forge.typo3.org/issues/108365 -
Lina Wolf commented on patch set 9 11/30/25, 06:02
Unresolved
Documentation changes: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6268