91877[FEATURE] Add console command to execute silent migrations
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 17
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/91877/17 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/91877/17 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Stefan Bürk -2
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
91877 [FEATURE] Add console command to execute silent migrations This change
-
main
92494[TASK] Create service to blind configuration options in a central place
The chain has patch set 1 of 3, the changes above it need a rebase.
Issues 1
Files 3
- typo3/sysext/core/Classes/Command/SettingsMigrationCommand.phpnew+178 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-106986-ModifyBlindedConfigurationOptionsEventMovedFromEXTlowlevelToEXTcore.rstnew+61 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-106986-AddConsoleCommandToExecuteSilentMigrations.rstnew+89 −0
Review log 3552
Show 1927 earlier messages
-
Lina Wolf uploaded patch set 1 11/25/25, 12:51
-
Lina Wolf marked it work in progress 11/25/25, 12:51
-
Mathias Brodala commented on patch set 1 11/25/25, 12:55
-
core-ci voted on patch set 1 V -1 11/25/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90948
-
Lina Wolf commented on patch set 1 11/25/25, 14:17
UpgradeSilentMigrationsCommand.php:50ReplyThis command can be run without database access and therefore in a pipeline that has none. It can be used to check the integrity of the settings.php -
Mathias Brodala commented on patch set 1 11/25/25, 14:24
UpgradeSilentMigrationsCommand.php:50ReplyHm, makes sense. Still wonder if upgrade:run could be adjusted accordingly. If kept, then "settings:migrate" or "configuration:migrate" would be clearer. -
Lina Wolf commented on patch set 1 11/25/25, 14:29
UpgradeSilentMigrationsCommand.php:50Replysettings:migrate might be a good name. This is still very much work in progress however and just some first thoughts. Not anywhere ready for review ;) upgrade:run needs a database as most upgrade wizards upgrade database rows. -
Lina Wolf uploaded patch set 2
V -111/25/25, 14:49 -
core-ci voted on patch set 2 V -1 11/25/25, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90958
-
Lina Wolf commented on patch set 2 11/25/25, 18:27
UpgradeSilentMigrationsCommand.php:50ReplyDone -
Lina Wolf uploaded patch set 3
V -112/04/25, 13:49 -
Lina Wolf uploaded patch set 4 12/04/25, 13:50
-
Lina Wolf uploaded patch set 5 12/04/25, 13:52
-
core-ci voted on patch set 3 V -1 12/04/25, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91590
-
core-ci voted on patch set 4 V -1 12/04/25, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91591
-
core-ci voted on patch set 5 V -1 12/04/25, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91592
-
Lina Wolf uploaded patch set 6
V -112/04/25, 16:39 -
Lina Wolf marked it ready for review 12/04/25, 16:44
-
core-ci voted on patch set 6 V -1 12/04/25, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91594
-
Lina Wolf uploaded patch set 7
V -112/04/25, 17:23 -
core-ci voted on patch set 7 V +1 12/04/25, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91598
-
Simon Schaufelberger commented on patch set 7 12/05/25, 11:08
SettingsMigrationCommand.php:64```suggestion 'Maximal number of tries.', ```SettingsMigrationCommand.php:148this looks very much like AI code. please remove the numberingConfigurationBlindingService.php:137move the is_array check into new lineConfigurationBlindingService.php:142make it one line -
Mathias Brodala commented on patch set 7 12/05/25, 11:20
ConfigurationBlindingService.php:137ReplyOr even better: if (isset($configuration['DB']['Connections']['Default'])) No need to check each array key, isset() already does that. The check for array is not necessary IMO. -
Lina Wolf commented on patch set 8
V +112/05/25, 11:25Published edit on patch set 7. -
Lina Wolf commented on patch set 8 12/05/25, 11:25
SettingsMigrationCommand.php:64ReplyFix applied. -
core-ci voted on patch set 8 V +1 12/05/25, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91644
-
Lina Wolf uploaded patch set 9
V +112/05/25, 11:35
-
Lina Wolf commented on patch set 9 12/05/25, 11:37
SettingsMigrationCommand.php:148ReplyI am very much able to use numbering myself, but the comment has become superfluous by properly named method names.ConfigurationBlindingService.php:137ReplyDoneConfigurationBlindingService.php:142ReplyDone -
core-ci voted on patch set 9 V -1 12/05/25, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91645
-
Lina Wolf uploaded patch set 10
V -112/06/25, 08:27 -
core-ci voted on patch set 10 V +1 12/06/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91722
-
Garvin Hicking commented on patch set 10 12/12/25, 11:52
duplicated paragraph -
Lina Wolf updated the commit message in patch set 11
V +112/13/25, 02:10 -
Lina Wolf commented on patch set 11 12/13/25, 02:10
Reply
Done -
core-ci voted on patch set 11 V +1 12/13/25, 02:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92171
-
Lina Wolf rebased onto patch set 12
V +101/10/26, 06:08 -
core-ci voted on patch set 12 V +1 01/10/26, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93188
-
Simon Praetorius commented on patch set 12 CR -1 01/10/26, 19:16
SettingsMigrationCommand.php:73This file must use `.bak.php` or similar as file extension. Otherwise we risk exposing credentials on systems where the webserver isn't properly configured to disallow access to var/transient/*.SettingsMigrationCommand.php:107The backup file must be deleted at the end.GlobalVariableProvider.php:49I would remove this comment.ConfigurationBlindingService.php:120I have the feeling that this service should be a pre-patch. There are two more usages of the event which remain in their original position. Also, the service is named generically, but includes special handling for DB connections, which is only relevant for TYPO3_CONF_VARS. -
Stefan Bürk commented on patch set 12 CR -2 01/10/26, 22:48
Unresolved
Will comment in detail later, but that change should not go in in that way. Short arguments: * Command should be provided by EXT:core and not EXT:lowlevel (optional). * The event should be moved to EXT:core (keeping the namespace) and deprecated, adding a new one in EXT:core with new namespace, dispatching both. Similar how I did/doing it for event(s) to move the language:update command: 91952: [WIP][TASK] Move command "language:update" to `EXT:core` | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91952 * Like Simon mentioned, the new "service" should be use a more suiting name, and also be provided in EXT:core instead of EXT:lowlevel. The main benefit of the commit is to have it available in pipelines (CI/CD) and it makes no sense to have it provided by a optional extension and forcing people to install the extension, use the command, and uninstall it when not required in deployed environment. To be honest, I did not a real review yet - just had a quick look and wanted to state the main pain points. Decided to give it a -2 temporary to ensure that this get not merged into the optional extension and **not** as a general block a.k.a. `we don't do that`. -
Lina Wolf uploaded patch set 13
CR -1V +101/24/26, 12:53Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 13 V -1 01/24/26, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94254
-
Lina Wolf uploaded patch set 14
V -101/24/26, 13:35Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Lina Wolf commented on patch set 14 01/24/26, 13:36
SettingsMigrationCommand.php:73ReplyDoneSettingsMigrationCommand.php:107ReplyDone -
core-ci voted on patch set 14 V +1 01/24/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94255
-
Lina Wolf uploaded patch set 15
V +101/24/26, 13:46Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Lina Wolf uploaded patch set 16 01/24/26, 13:49
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 15 V +1 01/24/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94256
-
core-ci voted on patch set 16 V +1 01/24/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94257
-
Lina Wolf rebased onto patch set 17
V +101/24/26, 14:23Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Lina Wolf commented on patch set 17 01/24/26, 14:24
GlobalVariableProvider.php:49ReplyDoneConfigurationBlindingService.php:120Reply -
core-ci voted on patch set 17 V +1 01/24/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94260
-
Lina Wolf marked it work in progress 01/25/26, 09:10
UpgradeSilentMigrationsCommand.php:50