91901[BUGFIX] Fix exceptions due to null as array key
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josua Vogel +1
- Sven Liebert +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Josua Vogel +1
- Sven Liebert +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2328
Show 23 earlier messages
-
Georg Ringer uploaded patch set 1 11/26/25, 20:51
-
Georg Ringer commented on patch set 1 11/26/25, 20:52
This change is ready for review. -
core-ci voted on patch set 1 V -1 11/26/25, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91047
-
Garvin Hicking commented on patch set 1 11/26/25, 21:29
i think we'd rather need to check the places where the vars are used as array keys rather than changing them from null ti a string, which might yield trouble in the codeflow -
Oliver Klee updated the commit message in patch set 2
V -111/26/25, 21:29 -
core-ci voted on patch set 2 V -1 11/26/25, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91049
-
Georg Ringer uploaded patch set 3
V -111/27/25, 08:12 -
core-ci voted on patch set 3 V +1 11/27/25, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91068
-
Georg Ringer uploaded patch set 4
V +111/27/25, 08:28 -
core-ci voted on patch set 4 V +1 11/27/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91070
-
Garvin Hicking commented on patch set 4 11/27/25, 11:20
NewRecordController.php:421my head doesn't yet work but maybe here instead of 'null' we could directly fallback to 'system' here, and also remove the lower assignment then? Nice idea to address this differently however, technically it would prevent the error and do everything as before :) -
Stefan Bürk commented on patch set 4 CR +1 V +1 11/27/25, 13:16
Reply
DoneNewRecordController.php:421Reply> my head doesn't yet work but maybe here instead of 'null' we could directly fallback to 'system' here, and also remove the lower assignment then? Nope, that would prevent the next line to be executed, using $nameParts[1] as fallback or at least try to do so and also all the other handling to find a group. -
Garvin Hicking commented on patch set 4 CR +1 V +1 11/27/25, 13:51
NewRecordController.php:421ReplyDone -
Sven Liebert voted on patch set 4 CR +1 V +1 11/27/25, 14:11
-
Oli Bartsch voted on patch set 4 CR +1 V +1 11/27/25, 14:51
-
Oliver Klee voted on patch set 4 CR +1 11/27/25, 15:03
-
Garvin Hicking commented on patch set 4 11/27/25, 19:44
Is 12.4 also affected and would need it for 8.5 compat? -
Eric Harrer commented on patch set 4 11/27/25, 22:33
Reply
Yes, it is (just tested), but PHP 8.5 is not officially supported by TYPO3 12.4. -
Eric Harrer voted on patch set 4 CR +1 V +1 11/27/25, 22:34
-
Stefan Bürk commented on patch set 4 11/27/25, 22:39
Reply
12.4 not having official 8.5 support according to communication on get.typo3.org. We leaving 12.4 out here. -
Garvin Hicking commented on patch set 4 11/27/25, 23:37
Reply
OK, just because https://review.typo3.org/c/Packages/TYPO3.CMS/+/91915 and a few other 8.5 things got ported to 12.4. -
Simon Schaufelberger uploaded patch set 5
CR +1V +101/17/26, 14:46 -
core-ci voted on patch set 5 V +1 01/17/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93681
-
Benni Mack voted on patch set 5 CR +1 V +1 01/19/26, 14:26
-
Josua Vogel voted on patch set 5 CR +1 V +1 01/19/26, 14:34
-
Sven Liebert voted on patch set 5 CR +1 V +1 01/19/26, 14:58
-
Georg Ringer voted on patch set 5 CR +2 V +2 01/19/26, 19:29
-
Georg Ringer merged patch set 6 01/19/26, 19:30