Review main Merged

91906[TASK] Reflect thrown exceptions in `ArrayUtility::getValueByPath()`

Elias Häußler CR +2 V +2 Easy +2 −2 updated 11/27/25, 14:42

Commit message

An `InvalidArgumentException` is never thrown in the method. However,
the possibly thrown `MissingArrayPathException` is not yet reflected
in the phpDoc, which is now resolved.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Elias Häußler uploaded patch set 1 11/27/25, 10:11

  2. core-ci voted on patch set 1 V +1 11/27/25, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91084

  3. Elias Häußler uploaded patch set 2 V +1 11/27/25, 10:21

  4. core-ci voted on patch set 2 V +1 11/27/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91086

  5. Stefan Bürk commented on patch set 2 CR +1 V +1 11/27/25, 13:27

    I guess the `\InvalidArgumentException` annotation was not removed back then adding native `array|string` argument type.
  6. Oliver Klee voted on patch set 2 CR +1 V +1 11/27/25, 14:11

  7. Sven Liebert voted on patch set 2 CR +1 V +1 11/27/25, 14:13

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 11/27/25, 14:23

  9. Stefan Bürk merged patch set 3 11/27/25, 14:42