Review 13.4 Abandoned

91912[WIP][BUGFIX] Do not persist site rootPageId with ENV content

Garvin Hicking CR -1 V -1 Easy +9 −3 updated 02/06/26, 16:10

Commit message

Review

  • Code review CR -1
    • Garvin Hicking -1
  • Verified V -1
    • core-ci -1 CI

Files 3

Review log 67

  1. Garvin Hicking uploaded patch set 1 11/27/25, 14:10

  2. Garvin Hicking marked it work in progress 11/27/25, 14:10

  3. core-ci voted on patch set 1 V -1 11/27/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91101

  4. Garvin Hicking commented on patch set 1 CR -1 11/27/25, 14:26

    SiteDatabaseEditRow.php:54 Unresolved

    note: i think this here is superfluous and makes the test fail. (Hooray for tests. We need to add a case for this kind of setup with placeholders, too!) Failing test is: TYPO3\CMS\Backend\Tests\Unit\Form\FormDataProvider\SiteDatabaseEditRowTest::addDataSetsDataForSysSite
  5. Garvin Hicking abandoned the change 01/14/26, 19:11

  6. Garvin Hicking restored the change 01/23/26, 08:13

  7. Garvin Hicking abandoned the change 02/06/26, 16:10