91919[BUGFIX] Use proper index for translation files added in cache-warmup to Symfony translator
Commit message
Review
-
Code review CR +1
- Benni Mack +1
-
Verified V +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 913
-
Ayke Halder uploaded patch set 1 11/27/25, 19:40
-
Ayke Halder uploaded patch set 2 11/27/25, 19:48
-
core-ci voted on patch set 1 V +1 11/27/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91132
-
core-ci voted on patch set 2 V +1 11/27/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91135
-
Ayke Halder updated the commit message in patch set 3
V +111/27/25, 22:48 -
core-ci voted on patch set 3 V +1 11/27/25, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91147
-
Sven Liebert commented on patch set 3 CR -1 11/28/25, 01:35
Reuse $dir for $shorthand -
Ayke Halder commented on patch set 3 11/28/25, 08:25
Reply
This is just a revert of the following change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91066/28/typo3/sysext/core/Classes/Localization/CacheWarmer.php I do not see a feasible way to reuse e.g. `$dir = "/var/www/html/typo3/sysext/backend/Resources/Private/Language"` for `$shorthand = "EXT:backend/Resources/Private/Language"` In general what this patch here is about: `$this->localizationFactory->getParsedData()` must be called with `shorthand` and not with `dir`. -
Sven Liebert commented on patch set 3 CR 0 11/28/25, 08:54
Reply
Yeah you are right. I misschecked that! :) -
Ayke Halder rebased onto patch set 4
V +111/28/25, 10:45 -
core-ci voted on patch set 4 V +1 11/28/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91195
-
Benni Mack voted on patch set 4 CR +1 V +1 12/04/25, 09:13
-
Ayke Halder abandoned the change 12/16/25, 19:41
in favour of 91947: [TASK] Manage localization fallback and load override files using Symfony Translator | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91947