Review main Abandoned

91919[BUGFIX] Use proper index for translation files added in cache-warmup to Symfony translator

Ayke Halder CR +1 V +1 Easy +6 −1 updated 12/16/25, 19:41

Commit message

The change I3caf7aac6c273b3874b1847e1f39827efb29f6f8 introduced a
deprecation by changing the resource index a.k.a. `domain-name` to
full resource path like
`/var/www/html/typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf`
instead of label `backend.siteconfiguration`.

Review

  • Code review CR +1
    • Benni Mack +1
  • Verified V +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 913

  1. Ayke Halder uploaded patch set 1 11/27/25, 19:40

  2. Ayke Halder uploaded patch set 2 11/27/25, 19:48

  3. core-ci voted on patch set 1 V +1 11/27/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91132

  4. core-ci voted on patch set 2 V +1 11/27/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91135

  5. Ayke Halder updated the commit message in patch set 3 V +1 11/27/25, 22:48

  6. core-ci voted on patch set 3 V +1 11/27/25, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91147

  7. Sven Liebert commented on patch set 3 CR -1 11/28/25, 01:35

    Reuse $dir for $shorthand
  8. Ayke Halder commented on patch set 3 11/28/25, 08:25

    Reply

    This is just a revert of the following change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91066/28/typo3/sysext/core/Classes/Localization/CacheWarmer.php I do not see a feasible way to reuse e.g. `$dir = "/var/www/html/typo3/sysext/backend/Resources/Private/Language"` for `$shorthand = "EXT:backend/Resources/Private/Language"` In general what this patch here is about: `$this->localizationFactory->getParsedData()` must be called with `shorthand` and not with `dir`.
  9. Sven Liebert commented on patch set 3 CR 0 11/28/25, 08:54

    Reply

    Yeah you are right. I misschecked that! :)
  10. Ayke Halder rebased onto patch set 4 V +1 11/28/25, 10:45

  11. core-ci voted on patch set 4 V +1 11/28/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91195

  12. Benni Mack voted on patch set 4 CR +1 V +1 12/04/25, 09:13

  13. Ayke Halder abandoned the change 12/16/25, 19:41

    in favour of 91947: [TASK] Manage localization fallback and load override files using Symfony Translator | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91947