91925[BUGFIX] Properly persist ENV variables in site config (rootPageId)
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Sven Liebert +1
- Rozbeh Chiryai Sharahi +1
-
Verified V +2 Done
- Garvin Hicking +2
- Timo Webler +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+9 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+13 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php+9 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+26 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+8 −1
- typo3/sysext/backend/Tests/Functional/Configuration/EnvPlaceholderProcessorTest.phpnew+70 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+58 −57
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+8 −7
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+1 −0
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvPlaceholderProcessor.php4new+130 −0
Review log 2842
Show 1017 earlier messages
-
Rozbeh Chiryai Sharahi uploaded patch set 1 11/28/25, 05:51
-
Rozbeh Chiryai Sharahi uploaded patch set 2 11/28/25, 05:58
-
core-ci voted on patch set 1 V -1 11/28/25, 06:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91171
-
core-ci voted on patch set 2 V -1 11/28/25, 06:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91172
-
Rozbeh Chiryai Sharahi uploaded patch set 3
V -111/28/25, 07:06 -
Rozbeh Chiryai Sharahi uploaded patch set 4 11/28/25, 07:12
-
core-ci voted on patch set 3 V -1 11/28/25, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91178
-
core-ci voted on patch set 4 V -1 11/28/25, 07:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91179
-
Rozbeh Chiryai Sharahi uploaded patch set 5
V -111/28/25, 07:24 -
core-ci voted on patch set 5 V +1 11/28/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91180
-
Rozbeh Chiryai Sharahi uploaded patch set 6
V +111/28/25, 08:24 -
core-ci voted on patch set 6 V -1 11/28/25, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91186
-
Garvin Hicking marked it work in progress 11/28/25, 08:41
-
Garvin Hicking commented on patch set 6 02/06/26, 11:09
You might want to check out / look at typo3/sysext/core/Classes/Configuration/Loader/YamlPlaceholderGuard.php -
Garvin Hicking uploaded patch set 7
V -102/06/26, 15:01 -
core-ci voted on patch set 7 V -1 02/06/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95301
-
Garvin Hicking uploaded patch set 8
V -102/06/26, 15:15
-
core-ci voted on patch set 8 V +1 02/06/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95304
-
Garvin Hicking marked it ready for review 02/06/26, 20:19
-
Garvin Hicking uploaded patch set 9
V +102/13/26, 07:41Refactor into specific processor -
core-ci voted on patch set 9 V -1 02/13/26, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95805
-
Garvin Hicking uploaded patch set 10
V -102/13/26, 08:15address CGL -
Garvin Hicking uploaded patch set 11 02/13/26, 08:18
-
core-ci voted on patch set 10 V -1 02/13/26, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95807
-
core-ci voted on patch set 11 V -1 02/13/26, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95808
-
Garvin Hicking commented on patch set 12
V -102/13/26, 08:30Published edit on patch set 11. -
core-ci voted on patch set 12 V +1 02/13/26, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95809
-
Rozbeh Chiryai Sharahi commented on patch set 12 02/13/26, 10:16
EnvPlaceholderProcessor.php:46no code anywhere uses this method neither with null nor with int. Introducing type-bluriness here is not necessary. Also $referenceArray is currently not used and should not be added -- I guess this unused arguments are there because you implement the `PlaceholderProcessorInterface` on this class, though you dont need to. This class is basically using the processor-list which runs a stack of implementations of `PlaceholderProcessorInterface`, but does not need itself to implement the `PlaceholderProcessorInterface` like the children do.EnvPlaceholderProcessor.php:54no code anywhere uses this method neither with null nor with int. Introducing type-bluriness here is not necessary. Also $referenceArray is currently not used and should not be added. probably unwanted sideeffect of implementing processor-interfaceEnvVariableProcessor.php:26I understand it can be convenient to not type-caste a yaml value to string, before using canProcess. However, I'd suggest to make this more declarative and do `if(!is_string($placeholder)) return false` as this is currently passing a possible int to str_containsEnvVariableProcessor.php:38This signature change is not needed. when calling `process` you should beforehand call `canProcess` (which is currently the case everywhere). On `canProcess` however it makes sense to me. -
Rozbeh Chiryai Sharahi commented on patch set 12 02/13/26, 10:24
EnvVariableProcessor.php:26ReplyThis code is actually not used in the branch at all, so i'd even revert the change, as it is out-of-scope to create this extra type `int` and the `Interface` also has `string` only -
Rozbeh Chiryai Sharahi uploaded patch set 13
V +102/13/26, 10:25 -
Rozbeh Chiryai Sharahi uploaded patch set 14 02/13/26, 10:32
-
core-ci voted on patch set 13 V -1 02/13/26, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95822
-
core-ci voted on patch set 14 V +1 02/13/26, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95824
-
Garvin Hicking commented on patch set 14 02/13/26, 10:54
Thanks, this seems to evolve into the right direction :)EnvPlaceholderProcessor.php:46ReplyExactly. And yes, the interface is it helpful here. Thanks.EnvPlaceholderProcessor.php:54ReplyDoneEnvVariableProcessor.php:26ReplyDoneEnvVariableProcessor.php:38ReplyDone -
Rozbeh Chiryai Sharahi commented on patch set 14 CR +1 02/13/26, 11:55
Short summary of the steps taken: - we introduced an `EnvPlaceholderProcessor` which uses the same logic as `YamlFileLoader` for `%env(...)%` resolving. - The `EnvPlaceholderProcessor` uses the already existing `EnvProcessorInterface` stack - `EnvPlaceholderProcessor` is used on various places in order to resolve env-var-based inputs of site configs in order to do specific checks. For instance root-page id must be an existing page, and we need to resolve the env-placeholder in order to check if the page actually exists. - ... however wo do not touch the input when writing back to site config otherwise `%env(ROOT_PAGE_ID)` would turn into the resolved value, similar to introducing `getenv(...)` on `settings.php`. - Tests where introduced - Code is none-breaking - I checked manually on TYPO3 GUI if it works. I tested in combination with othersites with hard-coded root-page-id and also in isolation. - Tests are passing For me this patch is ready and I am looking forward to thumbsup or more inputs. -
Garvin Hicking voted on patch set 14 CR +1 V +1 02/13/26, 12:26
-
Timo Webler commented on patch set 14 V +1 02/18/26, 07:20
I tested it. Everything works as expected. We have this problem with our setups, too. So I'm glad someone has solved it. 😊 -
Sven Liebert voted on patch set 14 CR +1 V +1 02/23/26, 18:23
-
Benni Mack commented on patch set 14 CR -2 02/24/26, 08:05
I need to review this properly. give me some time (= days) -
Benni Mack voted on patch set 14 CR 0 03/10/26, 13:01
-
Garvin Hicking voted on patch set 14 CR +2 V +2 03/10/26, 14:06
-
Garvin Hicking merged patch set 15 03/10/26, 14:13