91926[BUGFIX] Account for symfony/dependency-injection:7.4 incompatibility
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stephan Großberndt +1
- Markus Klein +1
- Stefan Bürk +1
- Achim Fritz +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2026
Show 1 earlier messages
-
Benjamin Franzke uploaded patch set 1 11/28/25, 08:05
-
Benjamin Franzke uploaded patch set 2 11/28/25, 08:08
-
core-ci voted on patch set 1 V -1 11/28/25, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91183
-
core-ci voted on patch set 2 V +1 11/28/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91184
-
Oli Bartsch commented on patch set 2 11/28/25, 08:39
-
Benjamin Franzke uploaded patch set 3
V +111/28/25, 08:41 -
Benjamin Franzke commented on patch set 3 11/28/25, 08:43
ResolveClassPass.php:33ReplySee https://review.typo3.org/c/Packages/TYPO3.CMS/+/91926/3//COMMIT_MSG#25, this is a copy of upstream code. I will for sure add a reference to the class header that this is a copy of the 7.3 upstream class. -
Benjamin Franzke uploaded patch set 4 11/28/25, 08:47
-
core-ci voted on patch set 3 V +1 11/28/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91188
-
core-ci voted on patch set 4 V -1 11/28/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91189
-
core-ci voted on patch set 4 V +1 11/28/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91189
-
Benjamin Franzke commented on patch set 4 11/28/25, 09:17
ResolveClassPass.php:33ReplyDone -
Garvin Hicking commented on patch set 4 11/28/25, 09:18
```suggestion Symfony added a non-optional `class_exists` check in `ResolveClassPass` ``````suggestion for the DI versions >=7.4 (including 8.0), which is no longer is guarded ``` -
Garvin Hicking commented on patch set 4 11/28/25, 09:19
thanks!ResolveClassPass.php:27```suggestion * class resolution that introduced an incompatibility with existing ``` -
Stefan Bürk commented on patch set 4 V +1 11/28/25, 09:22
Works for me in TYPO3 main(14), 13.4 and 12.4 -
Benjamin Franzke uploaded patch set 5
V +111/28/25, 09:56 -
Benjamin Franzke commented on patch set 5 11/28/25, 09:56
I also filed an upstream PR: https://github.com/symfony/symfony/pull/62544Reply
DoneReply
DoneResolveClassPass.php:27ReplyDone -
core-ci voted on patch set 5 V +1 11/28/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91192
-
Achim Fritz commented on patch set 5 V +1 11/28/25, 12:36
works for me on dev-main -
Stefan Bürk voted on patch set 5 CR +1 V +1 11/28/25, 13:18
-
Markus Klein commented on patch set 5 V -1 11/28/25, 14:40
tested this patch on a v12 instance, but still fails. checking why -
Markus Klein commented on patch set 5 CR +1 V +1 11/28/25, 14:44
Reply
It was a patch-issue on my side. works. thanks. -
Stephan Großberndt commented on patch set 5 V +1 12/01/25, 09:39
Works on 12.4.39 -
Stephan Großberndt commented on patch set 5 12/01/25, 09:39
Reply
Done -
Benjamin Franzke voted on patch set 5 CR +2 V +2 12/01/25, 10:33
-
Benjamin Franzke merged patch set 6 12/01/25, 10:34
ResolveClassPass.php:33