Review main Merged

91927[BUGFIX] Adjust Symfony Validator tests for 7.4 compatibility

Garvin Hicking CR +2 V +2 Easy +25 −14 updated 11/28/25, 10:25

Commit message

The number of arguments passed to error messages has been
raised in Symfony Validator 7.4 and thus no longer meets
the hard-coded structure in the test.

The tests are now adjusted to only test for the rendered
error message, making it independant from argument order
and count.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 11/28/25, 08:20

  2. core-ci voted on patch set 1 V +1 11/28/25, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91185

  3. core-ci commented on patch set 1 11/28/25, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91187

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/28/25, 09:06

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 11/28/25, 09:40

  6. Markus Klein voted on patch set 1 CR +1 V +1 11/28/25, 09:44

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 11/28/25, 10:24

  8. Garvin Hicking merged patch set 2 11/28/25, 10:25