Review main Abandoned

91929[BUGFIX] DataHandler: Filter AccessReadOnly records on page copy

Daniel Windloff CR 0 V -1 Easy +9 −0 updated 09/29/26, 11:28

Commit message

When copying a page, the page records are copied, too.
Add an early filter for all TCA tables with `TcaSchemaCapability::AccessReadOnly`
or non-existing TCA schema
to avoid error messages on copying pages.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 2

Files 1

Review log 810

  1. Daniel Windloff uploaded patch set 1 11/28/25, 10:28

  2. core-ci voted on patch set 1 V +1 11/28/25, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91194

  3. Daniel Siepmann commented on patch set 1 12/12/25, 09:43

    Thanks for providing this patch. That solves my problem … But I'm unable to see if there are downsides and side effects. It might be better to introduce a new PSR-14 event, Hook or configuration to specify certain tables to not be copied. That should not come with any side effects.
  4. Daniel Siepmann voted on patch set 1 V +1 12/12/25, 09:43

  5. Christian Kuhn commented on patch set 1 12/12/25, 11:33

    DataHandler.php:3562

    unsure. i don't understand why a read only record on a page should not be copied when the page is copied. why can in not be copied just because it should not be changed? i don't insist on this view, though. ctrl 'readonly' is a bit unclear in this regard. TCA docs say it is prod/display and phrase like this: "Records from this table may not be edited in the TYPO3 backend. Such tables are usually called "static". If set, this property is often combined with a ext_tables_static+adt.sql file to automatically populate the table with rows." i think we may need to sharpen 'readonly' a bit to make clear what we except from this flag in certain situations?
  6. Daniel Windloff commented on patch set 1 12/14/25, 09:02

    Reply

    I would prefer a TCA configuration in this case as it could be used to indicate the restriction for the user. An event would disable action, a user expects to have.

    DataHandler.php:3562 Reply Unresolved

    As far as I get it, readonly records are not copied as process_datamap filter out all readonly records (regardless of this change). This changes only removes an error message for the case, that a page with a readonly record is copied. Regardless, it is certainly useful to define which DataHandler actions are really supported; move (as action) is an particularly interesting case.
  7. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 07:13

  8. core-ci voted on patch set 2 V -1 04/22/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100845

  9. Christian Kuhn wrote 06/18/26, 23:04

    Removed cc Christian Kuhn.
  10. Daniel Windloff abandoned the change 09/29/26, 11:28

    Abandon in favor of the following patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75020