Review main Merged

91933[FEATURE] Add route enhancers to site sets

Benjamin Kott CR +2 V +2 Hard +513 −7 updated 12/05/25, 20:16

Commit message

Site sets can now define route enhancers in a dedicated
route-enhancers.yaml file. This allows extensions to provide
route enhancers as part of their site set configuration,
which are automatically merged into the site configuration
when the set is used as a dependency.

Route enhancers from site sets are applied as presets.
Site-level route enhancer configuration takes precedence
and can override set-defined enhancers. The merging uses
the same strategy as YAML imports: scalar values from
the site override set values, while new keys are appended.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1930

Show 35 earlier messages
  1. Benjamin Kott uploaded patch set 1 11/28/25, 15:37

  2. core-ci voted on patch set 1 V -1 11/28/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91213

  3. Benjamin Franzke updated the commit message in patch set 2 V -1 11/28/25, 15:53

  4. core-ci voted on patch set 2 V -1 11/28/25, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91214

  5. Benjamin Kott uploaded patch set 3 V -1 12/01/25, 10:58

  1. core-ci voted on patch set 3 V -1 12/01/25, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91342

  2. Benjamin Kott uploaded patch set 4 V -1 12/01/25, 13:07

  3. core-ci voted on patch set 4 V -1 12/01/25, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91358

  4. Benjamin Kott uploaded patch set 5 V -1 12/01/25, 14:51

  5. Benjamin Kott uploaded patch set 6 12/01/25, 14:55

  6. core-ci voted on patch set 5 V -1 12/01/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91366

  7. core-ci voted on patch set 6 V -1 12/01/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91367

  8. Benjamin Kott uploaded patch set 7 V -1 12/01/25, 15:13

  9. core-ci voted on patch set 7 V -1 12/01/25, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91369

  10. Benjamin Franzke uploaded patch set 8 V -1 12/01/25, 15:43

  11. Benjamin Franzke commented on patch set 8 12/01/25, 15:43

    on it

    Detail.fluid.html:330

    I don't like that Details view is become a mixture of "Information" and "debugging", but we can split that later and need to cleanup this view anyway.

    SiteConfiguration.php:296

    I think we first need to merge all sets one-after-the other first and then the route enhancers on top afterwards. Problably not important as long as `ArrayUtility::replaceAndAppendScalarValuesRecursive` is commutative, but in case we use a none cummutative merging strategy that would be important.

    YamlSetDefinitionProvider.php:115

    Let's allow empty as for `settings.yaml` (often a requirement for code genarators/templates :\)

    YamlSetDefinitionProvider.php:125

    First condition is currently a no-op.

    IsArrayViewHelper.php:32

    Let's move into `EXT:backend` for now.
  12. core-ci voted on patch set 8 V +1 12/01/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91371

  13. Benjamin Kott uploaded patch set 9 CR -1 V +1 12/02/25, 21:00

  14. Benjamin Kott commented on patch set 9 12/02/25, 21:00

    Reply

    Done

    SiteConfiguration.php:296 Reply

    Done

    YamlSetDefinitionProvider.php:115 Reply

    Done

    YamlSetDefinitionProvider.php:125 Reply

    Done

    IsArrayViewHelper.php:32 Reply

    Done
  15. core-ci voted on patch set 9 V +1 12/02/25, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91467

  16. Benjamin Franzke uploaded patch set 10 V +1 12/03/25, 07:41

  17. Benjamin Franzke voted on patch set 10 V +1 12/03/25, 07:45

  18. core-ci voted on patch set 10 V -1 12/03/25, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91504

  19. Benjamin Franzke uploaded patch set 11 CR +1 V +1 12/03/25, 08:05

  20. core-ci voted on patch set 11 V +1 12/03/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91508

  21. Soren Malling commented on patch set 11 12/05/25, 10:19

    If relevant or possible, can the RST contain a suggestion on how to work with "limitToPages" setting?
  22. Sven Liebert voted on patch set 11 CR +1 V +1 12/05/25, 20:01

  23. Benjamin Kott commented on patch set 11 12/05/25, 20:14

    Reply

    currently the same way as you do now, we talked about it, but we would need to expose settings to the enhancer configs in general and it also needs to work for configs that are not in sets. we will probably address this at a later point, but we considered it out of scope for now.
  24. Benjamin Kott voted on patch set 11 CR +2 V +2 12/05/25, 20:15

  25. Benjamin Kott merged patch set 12 12/05/25, 20:16