91933[FEATURE] Add route enhancers to site sets
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Sven Liebert +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/backend/Classes/ViewHelpers/Type/IsArrayViewHelper.phpnew+45 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Detail.fluid.html1+84 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php2+21 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+6 −1
- typo3/sysext/core/Classes/Site/Set/InvalidSetRouteEnhancersException.phpnew+41 −0
- typo3/sysext/core/Classes/Site/Set/SetDefinition.php+2 −0
- typo3/sysext/core/Classes/Site/Set/SetError.php+2 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php4+45 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-107837-RouteEnhancersInSiteSets.rstnew+131 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-107837-SitemapRouteEnhancersProvidedViaSiteSet.rstnew+36 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+18 −6
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptyRouteEnhancers/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptyRouteEnhancers/route-enhancers.yamlnew+0 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidRouteEnhancersMissingKey/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidRouteEnhancersMissingKey/route-enhancers.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidRouteEnhancersSuperfluousKey/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidRouteEnhancersSuperfluousKey/route-enhancers.yamlnew+7 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/SetWithRouteEnhancers/config.yamlnew+2 −0
Review log 1930
Show 35 earlier messages
-
Benjamin Kott uploaded patch set 1 11/28/25, 15:37
-
core-ci voted on patch set 1 V -1 11/28/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91213
-
Benjamin Franzke updated the commit message in patch set 2
V -111/28/25, 15:53 -
core-ci voted on patch set 2 V -1 11/28/25, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91214
-
Benjamin Kott uploaded patch set 3
V -112/01/25, 10:58
-
core-ci voted on patch set 3 V -1 12/01/25, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91342
-
Benjamin Kott uploaded patch set 4
V -112/01/25, 13:07 -
core-ci voted on patch set 4 V -1 12/01/25, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91358
-
Benjamin Kott uploaded patch set 5
V -112/01/25, 14:51 -
Benjamin Kott uploaded patch set 6 12/01/25, 14:55
-
core-ci voted on patch set 5 V -1 12/01/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91366
-
core-ci voted on patch set 6 V -1 12/01/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91367
-
Benjamin Kott uploaded patch set 7
V -112/01/25, 15:13 -
core-ci voted on patch set 7 V -1 12/01/25, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91369
-
Benjamin Franzke uploaded patch set 8
V -112/01/25, 15:43 -
Benjamin Franzke commented on patch set 8 12/01/25, 15:43
on itDetail.fluid.html:330I don't like that Details view is become a mixture of "Information" and "debugging", but we can split that later and need to cleanup this view anyway.SiteConfiguration.php:296I think we first need to merge all sets one-after-the other first and then the route enhancers on top afterwards. Problably not important as long as `ArrayUtility::replaceAndAppendScalarValuesRecursive` is commutative, but in case we use a none cummutative merging strategy that would be important.YamlSetDefinitionProvider.php:115Let's allow empty as for `settings.yaml` (often a requirement for code genarators/templates :\)YamlSetDefinitionProvider.php:125First condition is currently a no-op.IsArrayViewHelper.php:32Let's move into `EXT:backend` for now. -
core-ci voted on patch set 8 V +1 12/01/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91371
-
Benjamin Kott uploaded patch set 9
CR -1V +112/02/25, 21:00 -
Benjamin Kott commented on patch set 9 12/02/25, 21:00
Reply
DoneSiteConfiguration.php:296ReplyDoneYamlSetDefinitionProvider.php:115ReplyDoneYamlSetDefinitionProvider.php:125ReplyDoneIsArrayViewHelper.php:32ReplyDone -
core-ci voted on patch set 9 V +1 12/02/25, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91467
-
Benjamin Franzke uploaded patch set 10
V +112/03/25, 07:41 -
Benjamin Franzke voted on patch set 10 V +1 12/03/25, 07:45
-
core-ci voted on patch set 10 V -1 12/03/25, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91504
-
Benjamin Franzke uploaded patch set 11
CR +1V +112/03/25, 08:05 -
core-ci voted on patch set 11 V +1 12/03/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91508
-
Soren Malling commented on patch set 11 12/05/25, 10:19
If relevant or possible, can the RST contain a suggestion on how to work with "limitToPages" setting? -
Sven Liebert voted on patch set 11 CR +1 V +1 12/05/25, 20:01
-
Benjamin Kott commented on patch set 11 12/05/25, 20:14
Reply
currently the same way as you do now, we talked about it, but we would need to expose settings to the enhancer configs in general and it also needs to work for configs that are not in sets. we will probably address this at a later point, but we considered it out of scope for now. -
Benjamin Kott voted on patch set 11 CR +2 V +2 12/05/25, 20:15
-
Benjamin Kott merged patch set 12 12/05/25, 20:16