Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

91936[POC][FEATURE] Extbase Route Annotations

Benjamin Kott CR 0 V -1 Expert +1421 −15 updated 04/22/26, 06:09

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/91936/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/91936/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Files 22

Show 2 more files

Review log 89

  1. Benjamin Kott uploaded patch set 1 11/29/25, 01:23

  2. Benjamin Kott wrote 11/29/25, 01:23

    Set private
  3. Benjamin Kott marked it work in progress 01/24/26, 18:10

  4. Benjamin Kott marked it ready for review 03/24/26, 11:41

  5. Benjamin Kott wrote 03/24/26, 11:41

    Unset private
  6. Benjamin Kott uploaded patch set 2 03/24/26, 11:46

  7. core-ci voted on patch set 2 V -1 03/24/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98579

  8. Simon Schaufelberger commented on patch set 2 03/24/26, 13:56

    DebugFrontendRoutesCommand.php:54 Unresolved

    wouldn't it make sense to call it "output-format" and use "json" as a value? That would be more flexible for different formats.

    DebugFrontendRoutesCommand.php:82 Unresolved

    please wrap this extremely long line

    DebugFrontendRoutesCommand.php:129 Unresolved

    put io in the beginning as required argument

    DebugFrontendRoutesCommand.php:233 Unresolved

    put output in the beginning

    PageUriMatcher.php:102 Unresolved

    these 2 ifs could be combined into 1

    RouteAttributeCollector.php:31 Unresolved

    should we inject the cache via DI annotation here like we do it in other places as well instead of configuring it in the services.yaml?
  9. Benni Mack marked it work in progress 04/22/26, 06:09