Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
91936[POC][FEATURE] Extbase Route Annotations
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/91936/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/91936/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Files 22
- typo3/sysext/core/Classes/Command/DebugFrontendRoutesCommand.php4new+264 −0
- typo3/sysext/core/Classes/Routing/PageRouter.php+15 −4
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php1+16 −1
- typo3/sysext/core/Classes/Routing/RouteAttributeCollector.php1new+212 −0
- typo3/sysext/core/Classes/Routing/RouteEnhancerProviderInterface.phpnew+38 −0
- typo3/sysext/core/Classes/Routing/RouteEnhancerProviderRegistry.phpnew+61 −0
- typo3/sysext/core/Configuration/Services.yaml+12 −0
- typo3/sysext/extbase/Classes/EventListener/RouteAttributeCacheWarmupEventListener.phpnew+67 −0
- typo3/sysext/extbase/Classes/Routing/Attribute/FrontendRoute.phpnew+46 −0
- typo3/sysext/extbase/Classes/Routing/AttributeRouteEnhancerProvider.phpnew+194 −0
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+82 −10
- typo3/sysext/extbase/Configuration/Services.yaml+5 −0
- typo3/sysext/styleguide/Classes/Controller/Frontend/RouteAttributeExtbaseDemoController.phpnew+169 −0
- typo3/sysext/styleguide/Configuration/TCA/Overrides/tt_content.php+11 −0
- typo3/sysext/styleguide/Configuration/TypoScript/setup.typoscript+15 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+8 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Frontend/RouteAttributeExtbaseDemo/Archive.htmlnew+34 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Frontend/RouteAttributeExtbaseDemo/Create.htmlnew+38 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Frontend/RouteAttributeExtbaseDemo/List.htmlnew+59 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Frontend/RouteAttributeExtbaseDemo/New.htmlnew+36 −0
Review log 89
-
Benjamin Kott uploaded patch set 1 11/29/25, 01:23
-
Benjamin Kott wrote 11/29/25, 01:23
Set private -
Benjamin Kott marked it work in progress 01/24/26, 18:10
-
Benjamin Kott marked it ready for review 03/24/26, 11:41
-
Benjamin Kott wrote 03/24/26, 11:41
Unset private -
Benjamin Kott uploaded patch set 2 03/24/26, 11:46
-
core-ci voted on patch set 2 V -1 03/24/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98579
-
Simon Schaufelberger commented on patch set 2 03/24/26, 13:56
DebugFrontendRoutesCommand.php:54Unresolvedwouldn't it make sense to call it "output-format" and use "json" as a value? That would be more flexible for different formats.DebugFrontendRoutesCommand.php:82Unresolvedplease wrap this extremely long lineDebugFrontendRoutesCommand.php:129Unresolvedput io in the beginning as required argumentDebugFrontendRoutesCommand.php:233Unresolvedput output in the beginningPageUriMatcher.php:102Unresolvedthese 2 ifs could be combined into 1RouteAttributeCollector.php:31Unresolvedshould we inject the cache via DI annotation here like we do it in other places as well instead of configuring it in the services.yaml? -
Benni Mack marked it work in progress 04/22/26, 06:09