Review main Merged

91938[BUGFIX] Harden resource identifier recognition

Ayke Halder CR +2 V +2 Normal +52 −19 updated 12/04/25, 08:58

Commit message

Instead of checking for string prefix,
a pre-parsing is now applied to the resource
identifier, by exploding by : and using the first part
as resource type.

By doing so, the multiple if expression can now be exchanged
by a single match expression for extra clarity.

Tests are added to prove additional robustness.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1217

  1. Ayke Halder uploaded patch set 1 11/30/25, 13:31

  2. core-ci voted on patch set 1 V +1 11/30/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91294

  3. Ayke Halder uploaded patch set 2 V +1 12/01/25, 10:45

  4. core-ci voted on patch set 2 V +1 12/01/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91338

  5. Ayke Halder uploaded patch set 3 V +1 12/01/25, 10:58

  6. core-ci voted on patch set 3 V +1 12/01/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91341

  7. Oliver Klee updated the commit message in patch set 4 V +1 12/01/25, 11:21

  8. Oliver Klee voted on patch set 4 V +1 12/01/25, 11:21

  9. core-ci voted on patch set 4 V +1 12/01/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91343

  10. Helmut Hummel uploaded patch set 5 V +1 12/01/25, 13:56

  11. Helmut Hummel voted on patch set 5 CR +1 V +1 12/01/25, 13:56

  12. core-ci voted on patch set 5 V +1 12/01/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91361

  13. Oliver Klee voted on patch set 5 V +1 12/01/25, 14:07

  14. Garvin Hicking commented on patch set 5 CR +1 V +1 12/01/25, 21:59

    SystemResourceIdentifierFactoryTest.php:105

    Should we also have "EXTcore/..." without the "x" to confirm prior non-colon syntaxes? And how about a test for "EXT::core/..." paths and maybe "PKG:typo3/cms-core:/:Resources" or similar multiple colon uses? OTOH it might get paranoid easily, so I'd also be good with this approach.
  15. Helmut Hummel commented on patch set 5 12/03/25, 09:06

    SystemResourceIdentifierFactoryTest.php:105 Reply

    Yeah. I think we're in a good place with the code and tests
  16. Benni Mack voted on patch set 5 CR +2 V +2 12/04/25, 08:58

  17. Benni Mack merged patch set 6 12/04/25, 08:58