91943[BUGFIX] Account for symfony/dependency-injection:7.4 incompatibility
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Moritz Ngo +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Moritz Ngo +1
- core-ci +1 CI
Issues 1
Files 2
Review log 56
-
Benjamin Franzke commented on patch set 1 12/01/25, 09:58
Cherry Picked from branch 13.4. -
core-ci voted on patch set 1 V +1 12/01/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91334
-
Benjamin Franzke commented on patch set 1 CR +1 V +1 12/01/25, 10:24
Reproduced error and tested fix on v12 which is affected if symfony/dependency-injection 7.4 is used (e.g. when using PHP 8.4). Also tested the overwrite to be compatible with symfony/dependency-injection v6.4 (which is used when PHP 8.1 is in use). (Do not expected differently, since upstream `ResolveClassPass` use the same code in v6.4 and v7.3, only v7.4 changed). -
Moritz Ngo commented on patch set 1 CR +1 V +1 12/01/25, 10:30
works for me :) -
Benjamin Franzke voted on patch set 1 CR +2 V +2 12/01/25, 10:34
-
Benjamin Franzke merged patch set 2 12/01/25, 10:34