Review main Merged

91952[TASK] Move command "language:update" to `EXT:core`

Stefan Bürk CR +2 V +2 Hard +215 −57 updated 02/20/26, 21:07

Commit message

This change moves the CLI command "language:update" from
`EXT:install` into `EXT:core`, to allow language pack
downloads and updates during automatic deployments
without the need to have `EXT:install` installed in
composer-mode installations. This marks the next step on
making `EXT:install` more optional.

The following classes are moved:

* `\TYPO3\CMS\Install\Command\LanguagePackCommand` to
  `\TYPO3\CMS\Core\Command\UpdateLanguagePackCommand`

* `\TYPO3\CMS\Install\Service\LanguagePackService` to
  `\TYPO3\CMS\Core\Localization\LanguagePackService`, now marked
  as internal service.

The following PSR-14 events are moved from `EXT:install`
to `EXT:core`:

* `ModifyLanguagePackRemoteBaseUrlEvent`
* `ModifyLanguagePacksEvent`

The old class names are registered as aliases via
ClassAliasMap. Event listeners registered for the
deprecated event class names are transparently resolved
by the ListenerProvider via a deprecated event alias map,
triggering a runtime deprecation notice.

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2035

Show 510 earlier messages
  1. Stefan Bürk uploaded patch set 1 12/02/25, 01:45

  2. core-ci voted on patch set 1 V +1 12/02/25, 01:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91386

  3. Stefan Bürk uploaded patch set 2 V +1 12/02/25, 02:00

  4. core-ci voted on patch set 2 V +1 12/02/25, 02:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91387

  5. Stefan Bürk rebased onto patch set 3 V +1 12/02/25, 15:37

  6. core-ci voted on patch set 3 V +1 12/02/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91453

  7. Stefan Bürk rebased onto patch set 4 V +1 12/04/25, 10:46

  8. core-ci voted on patch set 4 V +1 12/04/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91582

  9. Stefan Bürk rebased onto patch set 5 V +1 12/09/25, 05:45

  10. core-ci voted on patch set 5 V +1 12/09/25, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91860

  1. core-ci commented on patch set 5 12/09/25, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91861

  2. Stefan Bürk uploaded patch set 6 V +1 01/12/26, 01:12

  3. core-ci voted on patch set 6 V +1 01/12/26, 01:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93247

  4. Lina Wolf updated the commit message in patch set 7 V +1 01/24/26, 13:50

  5. core-ci voted on patch set 7 V +1 01/24/26, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94258

  6. Stefan Bürk uploaded patch set 8 V +1 02/19/26, 19:32

  7. Stefan Bürk updated the commit message in patch set 9 02/19/26, 19:41

  8. core-ci voted on patch set 8 V -1 02/19/26, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96285

  9. core-ci voted on patch set 9 V +1 02/19/26, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96286

  10. Stefan Bürk uploaded patch set 10 V +1 02/19/26, 20:05

  11. core-ci voted on patch set 10 V +1 02/19/26, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96287

  12. Garvin Hicking updated the commit message in patch set 11 V +1 02/20/26, 08:18

  13. core-ci voted on patch set 11 V +1 02/20/26, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96314

  14. Garvin Hicking uploaded patch set 12 V +1 02/20/26, 08:57

  15. Garvin Hicking voted on patch set 12 CR +1 02/20/26, 09:01

  16. core-ci voted on patch set 12 V +1 02/20/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96317

  17. Benni Mack commented on patch set 12 CR -1 02/20/26, 09:22

    reviewing today.
  18. Benni Mack uploaded patch set 13 CR +1 V +1 02/20/26, 11:12

  19. core-ci voted on patch set 13 V +1 02/20/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96338

  20. Benni Mack uploaded patch set 14 V +1 02/20/26, 13:26

  21. core-ci voted on patch set 14 V +1 02/20/26, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96351

  22. Garvin Hicking commented on patch set 14 V -1 02/20/26, 19:16

    When testing this on a composer-based setup WITHOUT ext:install the backend cannot be executed: ``` Fri, 20 Feb 2026 19:14:06 +0000 [CRITICAL] request="9d78b65f36bd5" component="TYPO3.CMS.Core.Error.ProductionExceptionHandler": Core: Exception handler (WEB: BE): Error, code #0, file /var/www/html/typo3core/typo3/sysext/core/Classes/DependencyInjection/ServiceProviderRegistry.php, line 123: Class "TYPO3\CMS\Install\ServiceProvider" not found - {"mode":"WEB","application_mode":"BE","exception_class":"Error","exception_code":0,"file":"/var/www/html/typo3core/typo3/sysext/core/Classes/DependencyInjection/ServiceProviderRegistry.php","line":123,"message":"Class \"TYPO3\\CMS\\Install\\ServiceProvider\" not found","request_url":"http://localhost:28080/typo3","exception":null} ``` (My other tests in a setup WITH ext:install worked well, with old and new event listeners, on GUI and console boht)
  23. Garvin Hicking commented on patch set 14 CR +1 V +1 02/20/26, 19:32

    Reply

    OK I'm sorry. Even though I did clear my composer autoloader, the symfony DI cache folder, and the TYPO3 cache, it seems something else was stuck. After I restarted my whole docker setup it works now.
  24. Benni Mack voted on patch set 14 CR +2 V +2 02/20/26, 21:07

  25. Benni Mack merged patch set 15 02/20/26, 21:07