Review main Merged

91982[TASK] Handle ext:styleguide phpstan baseline entries

Torben Hansen CR +2 V +2 Easy +10 −37 updated 12/02/25, 18:40

Commit message

This change handles 3 ext:styleguide related phpstan
baseline entries by:

* defining `readonly` related attribute values as string
* removing superfluous `is_array` checks

The `OnFieldChangeTrait` related baseline item for
ext:styleguide remains, as this should be fixed
globally in ext:backend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Torben Hansen uploaded patch set 1 12/02/25, 13:03

  2. core-ci voted on patch set 1 V +1 12/02/25, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91441

  3. Benni Mack voted on patch set 1 CR +1 V +1 12/02/25, 13:44

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/02/25, 13:46

  5. Benni Mack voted on patch set 1 CR +2 V +2 12/02/25, 18:40

  6. Benni Mack merged patch set 2 12/02/25, 18:40