Review main Merged

91983[TASK] Disable shared memory usage for chrome testing images

Benjamin Franzke CR +2 V +2 Easy +7 −4 updated 01/28/26, 14:42

Commit message

Selenium suggests [1] to use a container shared memory size of 2GB
(to be passed via `--shm-size 2g` to docker) because chrome needs
more shared memory than provided by default in docker or podman.

It seems that the `tmpfs` mount on `/dev/shm` has been applied in #93575
(which "to deal with changed exceptions and behaviour"), for the same
reason.

runTests.sh executions with current docker versions (instead of our
default podman environment) revealed that the tmpfs mount leads
chrome into crashing from time to time.

Our testing infrastructure does not allow to specify `--shm-size 2g`
because our test runners do not run in host IPC namespace, but there
is another, better solution nowadays.

In the meantime chrome added support for disabling /dev/shm usage and
the developer suggested to use that:
https://issues.chromium.org/issues/40527382#comment77

For that reason we disable the tmpfs workaround and use the officially
supported cmdline flag instead.

[1] https://hub.docker.com/r/selenium/standalone-chrome
> When executing docker run for an image that contains a browser please
> use the flag --shm-size=2g to use the host's shared memory.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Benjamin Franzke uploaded patch set 1 12/02/25, 14:29

  2. core-ci voted on patch set 1 V -1 12/02/25, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91447

  3. Benjamin Franzke uploaded patch set 2 V -1 12/02/25, 14:37

  4. core-ci voted on patch set 2 V +1 12/02/25, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91448

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 12/02/25, 14:55

  6. core-ci voted on patch set 3 V +1 12/02/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91450

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 12/03/25, 16:14

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 12/08/25, 18:12

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/26/26, 08:36

  10. Guido Schmechel commented on patch set 3 CR +1 V +1 01/26/26, 09:40

    Special praise for the very detailed commit message!
  11. Benjamin Franzke commented on patch set 3 CR +2 V +2 01/28/26, 14:42

    Did a new CI run (based on main) via https://review.typo3.org/c/Packages/TYPO3.CMS/+/92552
  12. Benjamin Franzke merged patch set 4 01/28/26, 14:42