Review main Abandoned

91999[WIP][TASK] Playwright: Make tests more stable

Jochen Roth CR 0 V -1 Normal +147 −64 updated 04/21/26, 14:39

Commit message

@todo: verify the entire message.
Currently, a few tests turn out to be
flaky due to "await" being used on
locator.click().

This has been fixed by removing the await
when waiting for an event to get fired
after a click.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 16

Review log 4677

Show 3252 earlier messages
  1. Jochen Roth uploaded patch set 1 12/03/25, 21:50

  2. Jochen Roth updated the commit message in patch set 2 12/03/25, 21:53

  3. core-ci voted on patch set 1 V +1 12/03/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91555

  4. core-ci voted on patch set 2 V +1 12/03/25, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91556

  5. Oliver Klee voted on patch set 2 CR +1 12/04/25, 09:23

  6. Jochen Roth commented on patch set 2 CR -1 12/04/25, 13:23

    Will have a closer look at configuration-module-provider.spec.ts . It still fails sometimes. Most likely on the first run.
  7. Jochen Roth uploaded patch set 3 CR +1 V +1 12/04/25, 20:14

  8. Jochen Roth commented on patch set 3 12/04/25, 20:16

    Reply

    done
  9. core-ci voted on patch set 3 V -1 12/04/25, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91607

  10. Jochen Roth uploaded patch set 4 V -1 12/04/25, 20:28

  11. core-ci voted on patch set 4 V -1 12/04/25, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91609

  12. Jochen Roth uploaded patch set 5 V -1 12/04/25, 20:37

  13. core-ci voted on patch set 5 V +1 12/04/25, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91611

  14. Jochen Roth uploaded patch set 6 V +1 12/04/25, 20:54

  15. core-ci voted on patch set 6 V +1 12/04/25, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91612

  16. Jochen Roth uploaded patch set 7 V +1 12/04/25, 22:37

  17. Jochen Roth uploaded patch set 8 12/04/25, 22:43

  18. Jochen Roth uploaded patch set 9 12/04/25, 22:43

  19. core-ci voted on patch set 7 V +1 12/04/25, 22:45 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 8, 9 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91618

  20. core-ci voted on patch set 8 V +1 12/04/25, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91619

  21. core-ci voted on patch set 9 V +1 12/04/25, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91620

  22. Jochen Roth commented on patch set 9 CR -1 12/05/25, 14:52

    There is now one more flaky test: https://git.typo3.org/typo3/CI/cms/-/jobs/5105103 Will investigate
  23. Jochen Roth uploaded patch set 10 CR -1 V +1 12/05/25, 19:00

  24. Jochen Roth uploaded patch set 11 12/05/25, 19:00

  25. Jochen Roth uploaded patch set 12 12/05/25, 19:01

  26. Jochen Roth uploaded patch set 13 12/05/25, 19:01

  27. core-ci voted on patch set 10 V +1 12/05/25, 19:13 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 11, 12, 13 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91675

  28. core-ci voted on patch set 11 V +1 12/05/25, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91676

  29. core-ci voted on patch set 12 V +1 12/05/25, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91677

  30. core-ci voted on patch set 13 V +1 12/05/25, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91678

  31. Sven Liebert voted on patch set 13 CR +1 V +1 12/05/25, 20:51

  32. Jochen Roth uploaded patch set 14 CR +1 V +1 12/06/25, 22:59

  33. core-ci voted on patch set 14 V -1 12/06/25, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91754

  34. Jochen Roth uploaded patch set 15 V -1 12/06/25, 23:09

  35. core-ci voted on patch set 15 V +1 12/06/25, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91755

  36. Jochen Roth marked it work in progress 12/07/25, 00:13

  37. Jochen Roth commented on patch set 15 12/07/25, 00:15

    This change is ready for review.
    Now that all test are running locally using 1 worker and extensively tested using the `--repeat-each 5`, the file-clipboard test is flaky, but only in CI. See https://git.typo3.org/typo3/CI/cms/-/jobs/5110706
  38. Jochen Roth marked it work in progress 12/07/25, 00:15

  39. Jochen Roth uploaded patch set 16 V +1 12/07/25, 21:53

  40. Jochen Roth uploaded patch set 17 12/07/25, 21:57

  41. Jochen Roth uploaded patch set 18 12/07/25, 21:57

  42. Jochen Roth uploaded patch set 19 12/07/25, 21:57

  43. Jochen Roth uploaded patch set 20 12/07/25, 21:57

  44. Jochen Roth uploaded patch set 21 12/07/25, 22:01

  45. core-ci voted on patch set 20 V +1 12/07/25, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91789

  46. core-ci voted on patch set 21 V -1 12/07/25, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91790

  47. Jochen Roth uploaded patch set 22 V -1 12/10/25, 13:29

  48. core-ci voted on patch set 22 V +1 12/10/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91979

  49. Jochen Roth uploaded patch set 23 V +1 12/10/25, 13:39

  50. core-ci voted on patch set 23 V -1 12/10/25, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91981

  51. Jochen Roth rebased onto patch set 24 V -1 12/17/25, 15:05

  52. core-ci voted on patch set 24 V +1 12/17/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92352

  1. Jochen Roth uploaded patch set 25 V +1 12/17/25, 16:43

  2. Jochen Roth uploaded patch set 26 12/17/25, 16:43

  3. Jochen Roth uploaded patch set 27 12/17/25, 16:43

  4. Jochen Roth uploaded patch set 28 12/17/25, 16:43

  5. Jochen Roth uploaded patch set 29 12/17/25, 16:43

  6. Jochen Roth uploaded patch set 30 12/17/25, 16:43

  7. core-ci voted on patch set 25 V -1 12/17/25, 17:44 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 26, 27, 28, 29, 30 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92359

  8. core-ci voted on patch set 26 V -1 12/17/25, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92360

  9. core-ci voted on patch set 27 V -1 12/17/25, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92361

  10. core-ci voted on patch set 28 V -1 12/17/25, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92362

  11. core-ci voted on patch set 29 V -1 12/17/25, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92363

  12. core-ci voted on patch set 30 V -1 12/17/25, 17:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92364

  13. Jochen Roth uploaded patch set 31 V -1 12/19/25, 14:45

  14. core-ci voted on patch set 31 V -1 12/19/25, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92488

  15. Oliver Klee wrote 12/19/25, 15:53

    Removed reviewer Oliver Klee.
  16. Benni Mack uploaded patch set 32 V -1 01/29/26, 10:11

  17. core-ci voted on patch set 32 V -1 01/29/26, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94561

  18. Benni Mack uploaded patch set 33 V -1 01/29/26, 12:35

  19. core-ci voted on patch set 33 V -1 01/29/26, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94569

  20. Benni Mack uploaded patch set 34 V -1 02/13/26, 14:54

  21. core-ci voted on patch set 34 V -1 02/13/26, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95837

  22. Benni Mack uploaded patch set 35 V -1 02/13/26, 19:48

  23. core-ci voted on patch set 35 V -1 02/13/26, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95842

  24. Garvin Hicking commented on patch set 35 03/24/26, 09:50

  25. Benni Mack abandoned the change 04/21/26, 14:39

    not needed anymore