Review main Merged

92005[TASK] Lint XLIFF using XliffUtils::validateSchema()

Lina Wolf CR +2 V +2 Easy +19 −6 updated 12/05/25, 16:06

Commit message

Use Symfony's XliffUtils::validateSchema() to properly validate
XLIFF files against the official schemas. This ensures more reliable
and standards-compliant linting during core development.

Additionally, remove a stray leading greater-than sign from one
label. It produced no validation error, as it is legal in both XML
and XLIFF, but was unintended.

These issues were discovered while reviewing
https://review.typo3.org/c/Packages/TYPO3.CMS/+/91368

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 811

  1. Lina Wolf uploaded patch set 1 12/05/25, 11:50

  2. core-ci voted on patch set 1 V +1 12/05/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91646

  3. Lina Wolf uploaded patch set 2 V +1 12/05/25, 12:10

  4. core-ci voted on patch set 2 V +1 12/05/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91648

  5. Oliver Klee voted on patch set 2 CR +1 V +1 12/05/25, 12:24

  6. Lina Wolf uploaded patch set 3 CR +1 V +1 12/05/25, 14:25

  7. Oliver Klee voted on patch set 3 CR +1 12/05/25, 14:28

  8. core-ci voted on patch set 3 V +1 12/05/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91657

  9. Benni Mack voted on patch set 3 CR +1 V +1 12/05/25, 15:09

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 12/05/25, 16:06

  11. Garvin Hicking merged patch set 4 12/05/25, 16:06