Review main Abandoned

92008[DOCS] Clarify QR Code source_host and https intent

Garvin Hicking CR -1 V 0 Easy +20 −4 updated 01/14/26, 19:10

Commit message

This patch uses the proper "URI" term instead of "URL",
and also clarifies what `source_host` is used for,
as well as state that `https://` protocol is meant
to be fixed.

Review

  • Code review CR -1
    • Garvin Hicking -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 12/05/25, 14:14

  2. Simon Schaufelberger commented on patch set 1 12/05/25, 14:20

    Feature-107756-AddQRCodeModule.rst:44

    ```suggestion the contents of a generated QR code might not be useful. ```
  3. core-ci voted on patch set 1 V +1 12/05/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91653

  4. Garvin Hicking commented on patch set 2 V +1 12/05/25, 15:00

    Published edit on patch set 1.
  5. Garvin Hicking commented on patch set 2 CR -1 12/05/25, 15:01

    Let's wait on this. Simon might create a follow-up patch instead to allow specifying the protocol for dev/staging contexts so we can weigh in if we leave it hard-coded as is or not.

    Feature-107756-AddQRCodeModule.rst:44 Reply

    Fix applied.
  6. core-ci voted on patch set 2 V +1 12/05/25, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91662

  7. Garvin Hicking commented on patch set 2 12/11/25, 11:52

  8. Garvin Hicking abandoned the change 01/14/26, 19:10