Review main Merged

92009[BUGFIX] Correctly check for TSconfig boolean setting

Albrecht Köhnlein CR +2 V +2 Easy +1 −1 updated 12/08/25, 20:24

Commit message

The TSconfig option `checkhidden` is always passed as string to PHP. So
we cannot use a type-safe check against an integer.

This patch uses the same implementation as in all the other
cases of the same extension, by checking for a boolean `true`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Albrecht Köhnlein uploaded patch set 1 12/05/25, 14:16

  2. core-ci voted on patch set 1 V -1 12/05/25, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91654

  3. Albrecht Köhnlein updated the commit message in patch set 2 V -1 12/05/25, 14:42

  4. core-ci voted on patch set 2 V +1 12/05/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91660

  5. Garvin Hicking updated the commit message in patch set 3 V +1 12/05/25, 19:32

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 12/05/25, 19:33

  7. core-ci voted on patch set 3 V +1 12/05/25, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91679

  8. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 12/08/25, 19:13

  9. core-ci voted on patch set 4 V +1 12/08/25, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91831

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 12/08/25, 19:25

  11. Oliver Klee voted on patch set 4 CR +1 12/08/25, 19:33

  12. Garvin Hicking voted on patch set 4 CR +2 V +2 12/08/25, 19:35

  13. Garvin Hicking merged patch set 5 12/08/25, 20:24