Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
92010[BUGFIX] Respect onChange='reload' for file and inline fields
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 19
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/92010/19 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/92010/19 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 12
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+66 −7
- Build/Sources/TypeScript/backend/tests/drag-uploader-test.ts+23 −0
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −0
- Build/tests/playwright/e2e/form-engine/file.spec.ts+58 −0
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeTrait.php+21 −0
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+4 −0
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+4 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/backend/Tests/Functional/Form/Container/FilesControlContainerTest.php+55 −0
- typo3/sysext/backend/Tests/Functional/Form/Container/InlineControlContainerTest.phpnew+99 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_file.php+15 −1
Review log 3149
Show 1624 earlier messages
-
Wolfgang Klinger uploaded patch set 1 12/05/25, 14:19
-
core-ci voted on patch set 1 V -1 12/05/25, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91655
-
Wolfgang Klinger uploaded patch set 2
V -112/05/25, 14:49 -
core-ci voted on patch set 2 V +1 12/05/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91661
-
Wolfgang Klinger rebased onto patch set 3
V +112/05/25, 15:56 -
core-ci voted on patch set 3 V +1 12/05/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91668
-
Christian Kuhn commented on patch set 3 CR -1 12/08/25, 16:51
got a ping from josef glatz on this asking for a use case. temp -1, will update when i got some feedback. -
Wolfgang Klinger commented on patch set 3 12/09/25, 10:01
Reply
@lolli@schwarzbu.ch I don't know what to say about this specifically. The use case is the same as in other fields. When a medium/image is added or deleted, I want to be able to respond to this and dynamically change the view in the backend. -
Wolfgang Klinger uploaded patch set 4
CR -1V +112/16/25, 12:23 -
Wolfgang Klinger commented on patch set 4 12/16/25, 12:25
@lolli@schwarzbu.ch After a little feedback talk with Josef, I removed the notification for sequence changes (which I didn't need anyway). This means the patch is still helpful, but smaller. -
core-ci voted on patch set 4 V +1 12/16/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92293
-
Simon Schaufelberger uploaded patch set 5
V +101/19/26, 13:07 -
core-ci voted on patch set 5 V +1 01/19/26, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93774
-
Georg Ringer voted on patch set 5 CR +1 V +1 01/21/26, 20:12
-
Guido Schmechel voted on patch set 5 CR +1 V +1 01/25/26, 10:16
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 02/12/26, 21:29
-
Simon Schaufelberger uploaded patch set 6
CR +1V +103/07/26, 19:38 -
Simon Schaufelberger commented on patch set 6 CR +1 V +1 03/07/26, 19:39
That happens when a patch lays around for too long. All the votes are gone because of a merge conflict 😞 -
core-ci voted on patch set 6 V +1 03/07/26, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97549
-
Benni Mack updated the commit message in patch set 7
CR +1V +104/22/26, 06:41 -
core-ci voted on patch set 7 V +1 04/22/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100762
-
Wolfgang Klinger uploaded patch set 8
V +104/22/26, 09:50 -
Simon Schaufelberger uploaded patch set 9 05/09/26, 18:17
-
core-ci voted on patch set 9 V -1 05/09/26, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101757
-
Christian Kuhn wrote 06/18/26, 23:08
Removed reviewer Christian Kuhn. -
Benni Mack uploaded patch set 10
V -109/11/26, 23:21 -
Benni Mack rebased onto patch set 11 09/11/26, 23:21
-
core-ci voted on patch set 10 V -1 09/11/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108368
-
core-ci voted on patch set 11 V -1 09/11/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108369
-
Wolfgang Klinger uploaded patch set 12
V -109/12/26, 05:39 -
core-ci voted on patch set 12 V +1 09/12/26, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108385
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 09/12/26, 22:53
-
Wolfgang Klinger rebased onto patch set 13
CR +1V +109/24/26, 00:57 -
core-ci voted on patch set 13 V +1 09/24/26, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109124
-
Wolfgang Klinger rebased onto patch set 14
V +109/30/26, 13:58 -
core-ci voted on patch set 14 V +1 09/30/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109643
-
Simon Schaufelberger voted on patch set 14 CR +1 V +1 09/30/26, 20:57
-
Georg Ringer voted on patch set 14 CR +1 V +1 10/01/26, 18:57
-
Georg Ringer uploaded patch set 15
CR +1V +111/10/26, 18:53 -
core-ci voted on patch set 15 V +1 11/10/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113939
-
Benni Mack uploaded patch set 16
V +111/11/26, 14:19 -
core-ci voted on patch set 16 V -1 11/11/26, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114096
-
Benni Mack rebased onto patch set 17
V -111/11/26, 20:31 -
core-ci voted on patch set 17 V -1 11/11/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114144
-
Benni Mack rebased onto patch set 18
V -111/12/26, 17:07 -
core-ci voted on patch set 18 V -1 11/12/26, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114206
-
Wolfgang Klinger uploaded patch set 19
V -111/16/26, 13:39 -
core-ci voted on patch set 19 V +1 11/16/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114625
-
Simon Schaufelberger voted on patch set 19 CR +1 V +1 11/16/26, 14:57