Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

92010[BUGFIX] Respect onChange='reload' for file and inline fields

Wolfgang Klinger CR +1 V +1 Hard +349 −10 updated 11/16/26, 14:57

Commit message

Fields of type `file` and `type=inline` did not trigger the
configured `onChange='reload'` handler when child records were
added or removed. The rendering containers dropped the
`fieldChangeFunc` items passed by FormEngine, so no field-change
processing ever reached the form.

Both containers now serialise these items into a custom
`data-formengine-on-field-change` attribute on their web
component. The `UpdateValueOnFieldChange` item is left out, as the
container maintains the value of its field itself, and the
attribute is only rendered if any item remains.

The inline runtime processes the items once per user action:
adding several files via multi-selection or upload, as well as
synchronizing localizations, asks only once to save and refresh,
after all records have been added. While the drag uploader still
uploads files, processing is deferred; it dispatches the new event
`typo3:drag-uploader:upload-started` for this.

Adding a blank inline child does not process the items, as saving
right away would persist an empty record. Adding a child that
references an existing record (a file, a record chosen via
`foreign_selector`) and removing a persisted child do.

A custom attribute name (rather than the canonical
`data-formengine-field-change-event`/`-items`) is used to avoid
the global delegation in `form-engine.ts` matching change events
that bubble from descendant inputs through the container, which
would otherwise reload the form on every child field edit.

Reorder operations intentionally do not trigger the handler:
reload-on-drag would be hostile UX and is not part of the bug
being fixed.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 19
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/92010/19 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/92010/19 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 3149

Show 1624 earlier messages
  1. Wolfgang Klinger uploaded patch set 1 12/05/25, 14:19

  2. core-ci voted on patch set 1 V -1 12/05/25, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91655

  3. Wolfgang Klinger uploaded patch set 2 V -1 12/05/25, 14:49

  4. core-ci voted on patch set 2 V +1 12/05/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91661

  5. Wolfgang Klinger rebased onto patch set 3 V +1 12/05/25, 15:56

  6. core-ci voted on patch set 3 V +1 12/05/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91668

  7. Christian Kuhn commented on patch set 3 CR -1 12/08/25, 16:51

    got a ping from josef glatz on this asking for a use case. temp -1, will update when i got some feedback.
  8. Wolfgang Klinger commented on patch set 3 12/09/25, 10:01

    Reply

    @lolli@schwarzbu.ch I don't know what to say about this specifically. The use case is the same as in other fields. When a medium/image is added or deleted, I want to be able to respond to this and dynamically change the view in the backend.
  9. Wolfgang Klinger uploaded patch set 4 CR -1 V +1 12/16/25, 12:23

  10. Wolfgang Klinger commented on patch set 4 12/16/25, 12:25

    @lolli@schwarzbu.ch After a little feedback talk with Josef, I removed the notification for sequence changes (which I didn't need anyway). This means the patch is still helpful, but smaller.
  11. core-ci voted on patch set 4 V +1 12/16/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92293

  12. Simon Schaufelberger uploaded patch set 5 V +1 01/19/26, 13:07

  13. core-ci voted on patch set 5 V +1 01/19/26, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93774

  14. Georg Ringer voted on patch set 5 CR +1 V +1 01/21/26, 20:12

  15. Guido Schmechel voted on patch set 5 CR +1 V +1 01/25/26, 10:16

  16. Simon Schaufelberger voted on patch set 5 CR +1 V +1 02/12/26, 21:29

  17. Simon Schaufelberger uploaded patch set 6 CR +1 V +1 03/07/26, 19:38

  18. Simon Schaufelberger commented on patch set 6 CR +1 V +1 03/07/26, 19:39

    That happens when a patch lays around for too long. All the votes are gone because of a merge conflict 😞
  19. core-ci voted on patch set 6 V +1 03/07/26, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97549

  20. Benni Mack updated the commit message in patch set 7 CR +1 V +1 04/22/26, 06:41

  21. core-ci voted on patch set 7 V +1 04/22/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100762

  22. Wolfgang Klinger uploaded patch set 8 V +1 04/22/26, 09:50

  23. Simon Schaufelberger uploaded patch set 9 05/09/26, 18:17

  24. core-ci voted on patch set 9 V -1 05/09/26, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101757

  1. Christian Kuhn wrote 06/18/26, 23:08

    Removed reviewer Christian Kuhn.
  2. Benni Mack uploaded patch set 10 V -1 09/11/26, 23:21

  3. Benni Mack rebased onto patch set 11 09/11/26, 23:21

  4. core-ci voted on patch set 10 V -1 09/11/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108368

  5. core-ci voted on patch set 11 V -1 09/11/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108369

  6. Wolfgang Klinger uploaded patch set 12 V -1 09/12/26, 05:39

  7. core-ci voted on patch set 12 V +1 09/12/26, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108385

  8. Simon Schaufelberger voted on patch set 12 CR +1 V +1 09/12/26, 22:53

  9. Wolfgang Klinger rebased onto patch set 13 CR +1 V +1 09/24/26, 00:57

  10. core-ci voted on patch set 13 V +1 09/24/26, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109124

  11. Wolfgang Klinger rebased onto patch set 14 V +1 09/30/26, 13:58

  12. core-ci voted on patch set 14 V +1 09/30/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109643

  13. Simon Schaufelberger voted on patch set 14 CR +1 V +1 09/30/26, 20:57

  14. Georg Ringer voted on patch set 14 CR +1 V +1 10/01/26, 18:57

  15. Georg Ringer uploaded patch set 15 CR +1 V +1 11/10/26, 18:53

  16. core-ci voted on patch set 15 V +1 11/10/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113939

  17. Benni Mack uploaded patch set 16 V +1 11/11/26, 14:19

  18. core-ci voted on patch set 16 V -1 11/11/26, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114096

  19. Benni Mack rebased onto patch set 17 V -1 11/11/26, 20:31

  20. core-ci voted on patch set 17 V -1 11/11/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114144

  21. Benni Mack rebased onto patch set 18 V -1 11/12/26, 17:07

  22. core-ci voted on patch set 18 V -1 11/12/26, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114206

  23. Wolfgang Klinger uploaded patch set 19 V -1 11/16/26, 13:39

  24. core-ci voted on patch set 19 V +1 11/16/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114625

  25. Simon Schaufelberger voted on patch set 19 CR +1 V +1 11/16/26, 14:57