Review main Merged

92012[BUGFIX] Ensure EXT:scheduler records show interval frequency

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 12/08/25, 12:56

Commit message

The new TCA-based EXT:scheduler allows to set a task's frequency
with a "cronCmd" ("0 9,15 * * 1-5", ...) or an "interval" (seconds).

Saving a task with the "internval" configuration through the combobox
persisted the right data, but when re-displaying the value via
FormEngine, the persisted data would always only show the contents
of "cronCmd" (empty).

With this patch, in case "cronCmd" is empty, the interval will be
evaluated and used for the contents of the combobox.

This follows the same approach as in line 283 of
`EXT:scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php`:

```
$taskData['frequency'] = $taskObject->getExecution()->getCronCmd()
                       ?: $taskObject->getExecution()->getInterval();
```

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
    • Wolfgang Wagner +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Garvin Hicking uploaded patch set 1 12/05/25, 15:32

  2. core-ci voted on patch set 1 V +1 12/05/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91664

  3. Wolfgang Wagner voted on patch set 1 V +1 12/06/25, 11:12

  4. Lina Wolf commented on patch set 1 CR +1 V +1 12/07/25, 05:33

    Works great, code looks good
  5. Oli Bartsch voted on patch set 1 CR +2 V +2 12/08/25, 08:26

  6. Oli Bartsch merged patch set 2 12/08/25, 08:26

  7. Benni Mack commented on patch set 2 CR +1 12/08/25, 12:56

    Merged while a code review was still missing... Here it is. ;)