92013[BUGFIX] Fix invalid CSS selectors in adminpanel stylesheet
Commit message
Review
-
Code review CR -1 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Ayke Halder -1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1012
-
Benjamin Kott uploaded patch set 1 12/05/25, 15:36
-
core-ci voted on patch set 1 V +1 12/05/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91665
-
Benjamin Kott uploaded patch set 2
V +112/17/25, 11:27 -
core-ci voted on patch set 2 V +1 12/17/25, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92346
-
Oli Bartsch voted on patch set 2 CR +1 V +1 12/17/25, 21:59
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/17/25, 22:19
-
Benjamin Kott voted on patch set 2 CR +2 V +2 12/18/25, 07:29
-
Ayke Halder commented on patch set 2 12/18/25, 07:56
-
Ayke Halder voted on patch set 2 CR -1 12/18/25, 07:58
-
Benjamin Kott commented on patch set 2 12/18/25, 08:18
Gruntfile.js:199Replythis patch is not intended to optimize the size, even it would the impact would be minimal. it´s only to resolve the pending issue. we should take a different approach here in general for now it´s fine as is. -
Benjamin Kott merged patch set 3 12/18/25, 08:18
-
Ayke Halder commented on patch set 3 12/18/25, 19:03
Gruntfile.js:199ReplyShould have kept the size same as before. Anyway, to resolve the issue that would be the easier approach: ``` Subject: [PATCH] --- Index: Build/Sources/Sass/adminpanel.scss IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/Build/Sources/Sass/adminpanel.scss b/Build/Sources/Sass/adminpanel.scss --- a/Build/Sources/Sass/adminpanel.scss (revision 409bc042b3d0cf9a4a72a6c54be8f8213ee00038) +++ b/Build/Sources/Sass/adminpanel.scss (date 1766078248558) @@ -1,3 +1,4 @@ +@use "sass:meta"; // // Admin panel // =========== @@ -115,8 +116,16 @@ // Shared Components // #{$adminPanel-prefix} { - @import "component/icon"; - @import "typo3/element_tree"; + --icon-color-primary: currentColor; + --icon-size-small: 16px; + --icon-size-medium: 32px; + --icon-size-large: 48px; + --icon-size-mega: 64px; + --icon-unify-modifier: .86; + --icon-opacity-disabled: .5; + + @include meta.load-css("component/icon"); + @include meta.load-css("typo3/element_tree"); } #{$adminPanel-prefix} { ```
Gruntfile.js:199