92020[BUGFIX] Fix Extension Scanner crash on dynamic method calls
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcher.php+3 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php+2 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcher.php+3 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php+2 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcher.php+3 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php+2 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcher.php+3 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallMatcher.php+2 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallStaticMatcher.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcherTest.php+34 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcherTest.php+14 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php+42 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+15 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php+45 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcherTest.php+14 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcherTest.php+42 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+31 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallStaticMatcherTest.php+45 −0
Review log 2640
Show 1015 earlier messages
-
Sebastian Mendel uploaded patch set 1 12/06/25, 00:45
-
Sebastian Mendel uploaded patch set 2 12/06/25, 00:48
-
core-ci voted on patch set 1 V +1 12/06/25, 00:56 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91693
-
core-ci voted on patch set 2 V +1 12/06/25, 01:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91696
-
Garvin Hicking updated the commit message in patch set 3
V +112/06/25, 04:39 -
Garvin Hicking commented on patch set 3 12/06/25, 04:43
Good catch! Could you please add a test case / fixture for this scenario that fails wothout the patch and succeeds with these changes in place? That way we can prevent future regressions and fixate this behavior. Thanks! -
core-ci voted on patch set 3 V +1 12/06/25, 04:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91713
-
Sebastian Mendel uploaded patch set 4
V +112/06/25, 08:52 -
core-ci voted on patch set 4 V +1 12/06/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91725
-
Sebastian Mendel uploaded patch set 5
V +112/06/25, 09:03 -
core-ci voted on patch set 5 V +1 12/06/25, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91726
-
Garvin Hicking updated the commit message in patch set 6
V +112/06/25, 11:18 -
Garvin Hicking commented on patch set 6 12/06/25, 11:19
i've re-edited the commit message to add "Resolves" line and some code markup Lgtm, will check later -
Garvin Hicking commented on patch set 6 12/06/25, 11:26
Could you add ine test that uses the exact $var() call as in the issue? Effectively similar like your current calls, but a parser might still be variant in this and we should cover it at least once.
-
core-ci voted on patch set 6 V +1 12/06/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91728
-
Sebastian Mendel uploaded patch set 7
V +112/06/25, 13:31 -
Sebastian Mendel commented on patch set 7 12/06/25, 13:35
Reply
DoneReply
"Resolves: #108413" line was already there Do you mean "Releases: main, 14.0, 13.4"-line? is this something expected to be set by the patch provider? The patch is already provided for a specific branch, isn't it? -
Sebastian Mendel updated the commit message in patch set 8 12/06/25, 13:36
-
Sebastian Mendel updated the commit message in patch set 9 12/06/25, 13:38
-
core-ci voted on patch set 7 V +1 12/06/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91745
-
core-ci voted on patch set 8 V +1 12/06/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91746
-
core-ci voted on patch set 9 V +1 12/06/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91747
-
Garvin Hicking commented on patch set 9 12/06/25, 14:05
Reply
True I mixed it up. Am only mobile. The line is important to vote on the patch becaue it could not be merged without. The bug would qualify for a 13.4 backport, and I'm trying to keep it in sync with 14.0 too. -
Garvin Hicking commented on patch set 9 12/07/25, 19:57
Can you please check why these three tests do not actually fail without the patch to their matchers: typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallStaticMatcherTest.php (the others properly report failures) -
Netresearch DTT GmbH uploaded patch set 10
V +112/08/25, 11:24 -
Netresearch DTT GmbH uploaded patch set 11 12/08/25, 11:32
-
core-ci voted on patch set 10 V +1 12/08/25, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91820
-
core-ci voted on patch set 11 V +1 12/08/25, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91821
-
Christian Kuhn updated the commit message in patch set 12
V +112/08/25, 18:27 -
core-ci voted on patch set 12 V +1 12/08/25, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91830
-
Benni Mack updated the commit message in patch set 13
V +104/22/26, 06:38 -
Oliver Klee voted on patch set 13 CR +1 04/22/26, 07:43
-
core-ci voted on patch set 13 V -1 04/22/26, 07:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100746
-
Christian Kuhn rebased onto patch set 14
CR +1V -106/11/26, 15:27 -
Christian Kuhn commented on patch set 14 CR +1 V +1 06/11/26, 15:28
Reply
Donemmh. this is fine, right? let's get it done?! -
Oliver Klee voted on patch set 14 CR +1 V +1 06/11/26, 15:32
-
core-ci voted on patch set 14 V +1 06/11/26, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103410
-
Garvin Hicking commented on patch set 14 CR +2 V +2 06/11/26, 16:12
I think so, can't remember details. Lgtm. -
Garvin Hicking merged patch set 15 06/11/26, 17:06