92022[TASK] Avoid "Using null as an array offset is deprecated"
Commit message
Review
-
Code review CR +1
- Oliver Klee +1
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 1
Review log 810
-
Josef Glatz uploaded patch set 1 12/06/25, 05:46
-
Josef Glatz commented on patch set 1 12/06/25, 05:47
This change is ready for review. -
core-ci voted on patch set 1 V +1 12/06/25, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91720
-
Josef Glatz wrote 12/06/25, 06:11
Topic set to php-8.5 -
Stefan Bürk commented on patch set 1 12/06/25, 10:07
BackendUtility.php:2174```suggestion if (is_array($settings[$key ?? ''] ?? null) || !isset($MOD_MENU[$key ?? ''][$settings[$key ?? ''] ?? ''])) { ``` Possible that it is only me, but this change does not mitigate the > Using null as an array offset here completly. From my point of view the code needs to be adjusted like suggested. -
Garvin Hicking commented on patch set 1 12/07/25, 20:54
BackendUtility.php:2174Reply UnresolvedIf `$key` can be null, a few of the checks above would be adjusted too - in that case I guess we could even do an early continue if `$key === null` because most of the checks then would be superfluous?! -
Benni Mack updated the commit message in patch set 2
V +104/22/26, 06:38 -
Oliver Klee voted on patch set 2 CR +1 04/22/26, 07:44
-
core-ci voted on patch set 2 V -1 04/22/26, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100747
-
Georg Ringer abandoned the change 08/16/26, 12:32
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/93512