Review main Abandoned

92024[FEATURE] Add attribute-based registry for Extension Scanner matchers

Sebastian Mendel CR 0 V -1 Hard +357 −0 updated 12/06/25, 11:56

Commit message

This patch introduces a PHP attribute-based registry for Extension Scanner
matchers, replacing the need for manual iteration over matcher classes.

The implementation includes:

- ExtensionScannerMatcher: A PHP 8 attribute to mark classes as Extension
  Scanner matchers. The attribute optionally accepts a custom configuration
  file name.

- MatcherRegistry: A registry class that automatically discovers all matcher
  classes annotated with the ExtensionScannerMatcher attribute using
  reflection. It provides methods to get matcher classes, configurations,
  and create matcher instances.

- All 22 concrete matcher classes have been annotated with the new attribute.

Benefits:
- Self-registering matchers eliminate manual list maintenance
- Adding new matchers only requires adding the attribute to the class
- Configuration files are automatically resolved from class names
- Cleaner architecture following modern PHP patterns

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 25

Show 5 more files

Review log 23

  1. Sebastian Mendel uploaded patch set 1 12/06/25, 11:24

  2. core-ci voted on patch set 1 V -1 12/06/25, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91729

  3. Sebastian Mendel abandoned the change 12/06/25, 11:56