Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
92025[FEATURE] Add attribute-based registry for Extension Scanner matchers
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/92025/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/92025/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Files 25
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ArrayDimensionMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ArrayGlobalMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ClassConstantMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ClassNameMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstantMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ExtensionScannerMatcher.php1new+50 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/FunctionCallMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodAnnotationMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallStaticMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyAnnotationMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcher.php+1 −0
Show 5 more files
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyProtectedMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyPublicMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ScalarStringMatcher.php+1 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/MatcherRegistry.php1new+169 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/MatcherRegistryTest.phpnew+311 −0
Review log 712
-
Sebastian Mendel uploaded patch set 1 12/06/25, 11:52
-
core-ci voted on patch set 1 V +1 12/06/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91730
-
Sebastian Mendel uploaded patch set 2 12/06/25, 12:00
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 2 V +1 12/06/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91731
-
Sebastian Mendel uploaded patch set 3
V +112/06/25, 12:33 -
Sebastian Mendel uploaded patch set 4 12/06/25, 12:44
-
core-ci voted on patch set 3 V -1 12/06/25, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91736
-
core-ci voted on patch set 4 V +1 12/06/25, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91738
-
Sebastian Mendel uploaded patch set 5
V +112/06/25, 13:10 -
core-ci voted on patch set 5 V +1 12/06/25, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91744
-
Garvin Hicking commented on patch set 5 12/06/25, 13:38
Unresolved
(We'll also need a "Resolves" line and a feature rest.)ExtensionScannerMatcher.php:40UnresolvedNice! I think we should name this AsExtensionScannerMatcher though to be in line with most our custom attributes. Great you got on this so quickly -
Garvin Hicking commented on patch set 5 12/06/25, 13:54
MatcherRegistry.php:90UnresolvedI think this needs integration with Symfony DI and regular autoloading. Maybe check out https://review.typo3.org/c/Packages/TYPO3.CMS/+/91161 How to use it with service locators.