Review main Merged

92026[BUGFIX] Correct cache lifetime calculation for pages

Sascha Nowak CR +2 V +2 Easy +8 −1 updated 12/08/25, 17:53

Commit message

Page cache lifetime is calculated differently from
other records. The current implementation in
ContentObjectRenderer doesn’t account for this
difference, resulting in incorrect lifetime values.
It is ok to skip lifetime calculation for pages table
records in ContentObjectRenderer, details are added as
inline code comment.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Sascha Nowak +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1219

  1. Sascha Nowak uploaded patch set 1 12/06/25, 12:11

  2. core-ci voted on patch set 1 V -1 12/06/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91732

  3. Sascha Nowak uploaded patch set 2 V -1 12/06/25, 12:47

  4. core-ci voted on patch set 2 V -1 12/06/25, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91739

  5. Sascha Nowak uploaded patch set 3 V -1 12/06/25, 16:03

  6. core-ci voted on patch set 3 V -1 12/06/25, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91750

  7. Sascha Nowak uploaded patch set 4 V -1 12/06/25, 16:46

  8. core-ci voted on patch set 4 V +1 12/06/25, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91751

  9. Sascha Nowak uploaded patch set 5 V +1 12/08/25, 17:30

  10. Sascha Nowak uploaded patch set 6 12/08/25, 17:30

  11. Christian Kuhn uploaded patch set 7 12/08/25, 17:36

  12. Sascha Nowak voted on patch set 7 CR +1 V +1 12/08/25, 17:38

  13. Christian Kuhn voted on patch set 7 CR +1 V +1 12/08/25, 17:38

  14. core-ci voted on patch set 5 V +1 12/08/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91825

  15. core-ci voted on patch set 6 V +1 12/08/25, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91826

  16. core-ci voted on patch set 7 V +1 12/08/25, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91827

  17. Garvin Hicking voted on patch set 7 CR +1 V +1 12/08/25, 17:45

  18. Christian Kuhn voted on patch set 7 CR +2 V +2 12/08/25, 17:47

  19. Christian Kuhn merged patch set 8 12/08/25, 17:53