Review main Merged

92033[TASK] Handle ext:scheduler phpstan baseline entries

Torben Hansen CR +2 V +2 Easy +12 −29 updated 12/08/25, 12:56

Commit message

This change handles all phpstan baseline entries for
ext:scheduler by adding the following code changes:

`NormalizeCommand::normalizeIntegerField()`

The condition does never match, because `$fieldValues`
will always have a value. The else-branch will throw an
exception, if the given expression can not be normalized.
This scenario is also covered by unit tests. The
superfluous check for `$fieldValues` containing an empty
string has therefore been removed.

`NormalizeCommand::reduceListOfValuesByStepValue()`

The variable `$stepValuesAndStepArrayCount` can never be
less than 1, because the `explode` function on the non-empty
string `$stepExpression` will always result in an array with
at lease one item. The condition has therefore been adapted
to only check, if `$stepValuesAndStepArrayCount > 2`.

`CronCommand::dayMatchesCronCommand()`

The condition has been simplified by splitting it into
several parts and using early returns. This also makes
the function flow better readable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Torben Hansen uploaded patch set 1 12/07/25, 12:28

  2. core-ci voted on patch set 1 V +1 12/07/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91777

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 12/08/25, 12:55

  4. Benni Mack voted on patch set 1 CR +2 V +2 12/08/25, 12:56

  5. Benni Mack merged patch set 2 12/08/25, 12:56