Review main Ready for review Quiet

92034[TASK] Add explicit handling for deprecated labels in search

Lina Wolf CR 0 V 0 Normal +160 −4 updated 10/10/26, 06:40

Commit message

Previously, the EXT:lowlevel command `language:domain:search` always
displayed deprecated labels without indicating their status, making it
difficult to identify and clean up deprecated localization labels.

Two new options now provide explicit control over deprecated label
handling:

* `--include-deprecated` (alias `-d`) includes deprecated labels and
  marks them visually in the output.
* `--only-deprecated` shows only deprecated labels.

By default, deprecated labels are no longer shown. The internal
filtering logic has been updated to consistently include, exclude, or
mark deprecated labels across both flat and domain-grouped search
results.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92034/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92034/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 7

Review log 915

  1. Lina Wolf uploaded patch set 1 12/07/25, 12:49

  2. core-ci voted on patch set 1 V +1 12/07/25, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91778

  3. Lina Wolf rebased onto patch set 2 V +1 01/10/26, 06:04

  4. core-ci voted on patch set 2 V +1 01/10/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93186

  5. Simon Praetorius commented on patch set 2 01/10/26, 17:46

    TranslationDomainSearchCommand.php:187

    `deprecated` sounds to me like it would only display deprecated labels. How about `include-deprecated` (like in `impexp:export`) or `all` (like in `site:sets:list`)?

    TranslationDomainSearchCommand.php:250

    The condition is a bit confusing to me. How about we name the method `filterLabels()`, pass both flags to the method and decide in that method if and what needs to be filtered (e. g. with early returns)?

    TranslationDomainSearchCommand.php:318

    Since it's always a bool, I would use `if ($data->deprecated)` or with `... === true`.
  6. Benni Mack commented on patch set 2 10/07/26, 14:14

    ping, how do we continue here?
  7. Lina Wolf uploaded patch set 3 V +1 10/09/26, 08:18

  8. core-ci voted on patch set 3 V -1 10/09/26, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110561

  9. Lina Wolf rebased onto patch set 4 V -1 10/09/26, 10:08

  10. core-ci voted on patch set 4 V -1 10/09/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110578

  11. Lina Wolf updated the commit message in patch set 5 V -1 10/09/26, 17:29

  12. core-ci voted on patch set 5 V -1 10/09/26, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110660

  13. Lina Wolf uploaded patch set 6 V -1 10/10/26, 06:30

  14. core-ci voted on patch set 6 V +1 10/10/26, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110757

  15. Lina Wolf commented on patch set 6 10/10/26, 06:40

    Reply

    pong, I resolved all open comments please continute with reviews

    TranslationDomainSearchCommand.php:187 Reply

    Done, renamed to --include-deprecated

    TranslationDomainSearchCommand.php:250 Reply

    Replaced by a DeprecatedLabels enum. The command picks it once and passes it to LabelFinder.

    TranslationDomainSearchCommand.php:318 Reply

    Done.