92034[TASK] Add explicit handling for deprecated labels in search
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92034/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/34/92034/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/lowlevel/Classes/Command/TranslationDomainSearchCommand.php6+32 −2
- typo3/sysext/lowlevel/Classes/Localization/Dto/LabelSearchResult.php+1 −0
- typo3/sysext/lowlevel/Classes/Localization/DeprecatedLabels.phpnew+39 −0
- typo3/sysext/lowlevel/Classes/Localization/LabelFinder.php+8 −2
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/Extensions/test_label_finder/Resources/Private/Language/locallang.xlfnew+14 −0
- typo3/sysext/lowlevel/Tests/Functional/Fixtures/Extensions/test_label_finder/composer.jsonnew+18 −0
- typo3/sysext/lowlevel/Tests/Functional/Localization/LabelFinderTest.php+48 −0
Review log 915
-
Lina Wolf uploaded patch set 1 12/07/25, 12:49
-
core-ci voted on patch set 1 V +1 12/07/25, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91778
-
Lina Wolf rebased onto patch set 2
V +101/10/26, 06:04 -
core-ci voted on patch set 2 V +1 01/10/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93186
-
Simon Praetorius commented on patch set 2 01/10/26, 17:46
TranslationDomainSearchCommand.php:250The condition is a bit confusing to me. How about we name the method `filterLabels()`, pass both flags to the method and decide in that method if and what needs to be filtered (e. g. with early returns)?TranslationDomainSearchCommand.php:318Since it's always a bool, I would use `if ($data->deprecated)` or with `... === true`. -
Benni Mack commented on patch set 2 10/07/26, 14:14
ping, how do we continue here? -
Lina Wolf uploaded patch set 3
V +110/09/26, 08:18 -
core-ci voted on patch set 3 V -1 10/09/26, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110561
-
Lina Wolf rebased onto patch set 4
V -110/09/26, 10:08 -
core-ci voted on patch set 4 V -1 10/09/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110578
-
Lina Wolf updated the commit message in patch set 5
V -110/09/26, 17:29 -
core-ci voted on patch set 5 V -1 10/09/26, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110660
-
Lina Wolf uploaded patch set 6
V -110/10/26, 06:30 -
core-ci voted on patch set 6 V +1 10/10/26, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110757
-
Lina Wolf commented on patch set 6 10/10/26, 06:40
Reply
pong, I resolved all open comments please continute with reviewsTranslationDomainSearchCommand.php:187ReplyDone, renamed to --include-deprecatedTranslationDomainSearchCommand.php:250ReplyReplaced by a DeprecatedLabels enum. The command picks it once and passes it to LabelFinder.TranslationDomainSearchCommand.php:318ReplyDone.
TranslationDomainSearchCommand.php:187