Review main Merged

92038[TASK] Add symfony/console 7.4.1 compatibility to CliCommandTest

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 12/08/25, 17:36

Commit message

With Symfony 7.4.1 a change was made on how interactive input
was evaluated, and no longer failing on the CliCommandTest of TYPO3.

This change adapts the test to not expect a failure, but instead
accept a "success" exit code, by removing the interaction argument
and using a "dry-run".

The modification also revealed that passing args was missing a
command substitution placeholder, which is now added the calls
of:

 - referenceindex:update (--check)
 - cleanup:localprocessedfiles (-v)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Lina Wolf +1
    • Christian Kuhn +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • Christian Kuhn +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Garvin Hicking uploaded patch set 1 12/08/25, 09:08

  2. core-ci voted on patch set 1 V -1 12/08/25, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91811

  3. core-ci commented on patch set 1 12/08/25, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91812

  4. Garvin Hicking uploaded patch set 2 V -1 12/08/25, 09:49

  5. core-ci voted on patch set 2 V +1 12/08/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91814

  6. core-ci commented on patch set 2 12/08/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91815

  7. Lina Wolf voted on patch set 2 CR +1 V +1 12/08/25, 10:43

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/08/25, 10:45

  9. Oliver Klee voted on patch set 2 CR +1 12/08/25, 10:55

  10. Sven Liebert voted on patch set 2 CR +1 V +1 12/08/25, 10:55

  11. Christian Kuhn voted on patch set 2 CR +1 V +1 12/08/25, 17:28

  12. Garvin Hicking voted on patch set 2 CR +2 V +2 12/08/25, 17:36

  13. Garvin Hicking merged patch set 3 12/08/25, 17:36