92056[FEATURE] Add "datetimesec" TCA FormEngine format option
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Josua Vogel +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Josua Vogel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 46
- Build/phpstan/phpstan-baseline.neon+0 −6
- Build/Sources/TypeScript/backend/date-time-picker.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine-validation.ts+1 −0
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+14 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+3 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php4+17 −0
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Element/AbstractFormElementTest.php+21 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+19 −0
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Domain/DateTimeFactory.php+2 −1
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/FieldFormat.php+3 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108431-AddTCAdatetimeformatdatetimesecoption.rst3new+70 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+64 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/Result.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultBerlinLocaltime.csv+2 −2
Show 26 more files
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultEmpty.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultNull.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetBerlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetUTC.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultUTC0Berlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultZeroBerlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultZeroUTC.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Result.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultBerlinLocaltime.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultEmpty.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultNull.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultOffsetBerlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultOffsetUTC.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultUTC0Berlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultZeroBerlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultZeroUTC.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeLegacyTest.php+2 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeTest.php+30 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime/Configuration/TCA/tx_testdatahandler_datetime.php+31 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/Configuration/TCA/tx_testdatahandler_datetime_legacy.php+13 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+17 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+3 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatDatetimesec.phpnew+45 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+52 −0
- typo3/sysext/styleguide/Configuration/Services.yaml+1 −0
Review log 2733
Show 58 earlier messages
-
Garvin Hicking uploaded patch set 1 12/09/25, 11:04
-
core-ci voted on patch set 1 V -1 12/09/25, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91877
-
Garvin Hicking uploaded patch set 2
V -112/09/25, 19:14 -
core-ci voted on patch set 2 V -1 12/09/25, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91927
-
Garvin Hicking uploaded patch set 3
V -112/09/25, 19:29 -
core-ci voted on patch set 3 V +1 12/09/25, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91928
-
Georg Ringer commented on patch set 3 12/09/25, 20:18
nice one!BackendUtility.php:888at least return type would be nice -
Oli Bartsch commented on patch set 3 12/09/25, 20:29
This should be a separate patch please.
-
Stefan Bürk commented on patch set 3 12/09/25, 21:04
Reply
And if you are on it to extract into dedicated patchen .. can we please move the `Build/Scripts/rst*.rst` template files in dedicated folder to have them not directly on the same level like the scripts, please ? * `Build/rstTemplate/*.rst` (would prefer that one) * `Build/Scripts/rstTemplates/*.rst` * ... for example. Thanks. -
Garvin Hicking commented on patch set 3 CR -1 12/09/25, 21:25
Reply
Yes, good idea. Will do that tomorrow. -
Garvin Hicking commented on patch set 3 12/09/25, 21:26
BackendUtility.php:888ReplyWill do for the new method; my intent was to go low-impactful, but I see that types are mandatory for new code. Thanks! -
Garvin Hicking uploaded patch set 4
CR -1V +112/10/25, 08:03 -
Garvin Hicking commented on patch set 4 12/10/25, 08:04
BackendUtility.php:888ReplyDone -
core-ci voted on patch set 4 V +1 12/10/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91966
-
Benjamin Franzke commented on patch set 4 12/10/25, 13:17
DefaultConfigurationDescription.yaml:93Let's not add a new option for the formatting of this type, we do not have an option for `timesec` either, which is (i guess) because editing times including seconds basically always requires `H:i:s` (in all timezones)? Or maybe I'm mistaken?Feature-108431-AddTCAdatetimeformatdatetimesecoption.rst:50Maybe we should just validate and disallow such configuration, alhtough we (unfortunately do not do that for older, invalid combinations)? -
Garvin Hicking commented on patch set 4 12/10/25, 13:58
DefaultConfigurationDescription.yaml:93ReplyI was secretly hoping you'd say that, it would reduce complexity of course. I didn't check too much into the timesec->time parsing (because my use case only covered "datetime" cases), so I was not sure because "datetime" offered this flexibility that we would need it for displaying the "hor/minute/seconds" part of that. I can happily fixate this on "H:i:s" if there's no disagreement.Feature-108431-AddTCAdatetimeformatdatetimesecoption.rst:50ReplyI kind of regarded this as a "feature" to be able to use the "full picker" and still normalize seconds away from the input. There is some code that chooses the allowed format depending on the dbType which I could use for it. But for now I thought we could keep it broadly to allow configurations, that I couldn't rule out as useful. Also here I'm happy to add restrictions to this, whatever the agreement would be. I'm not fighting for it. ;) -
Garvin Hicking uploaded patch set 5
V +112/11/25, 07:50 -
Garvin Hicking commented on patch set 5 12/11/25, 07:52
DefaultConfigurationDescription.yaml:93ReplyI thought about this some more and think a fixed 'H:i:s' is fine, adjusted the patch.Feature-108431-AddTCAdatetimeformatdatetimesecoption.rst:50ReplyI modified the patch now to throw an exception for this misconfiguration, please check if the wording is fine with you. -
core-ci voted on patch set 5 V +1 12/11/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92051
-
Simon Schaufelberger voted on patch set 5 CR +1 12/11/25, 13:52
-
Christian Kuhn commented on patch set 5 12/11/25, 21:01
this looks good to me an reading at first glance already. i hope to find a slot to give it a testing slot within the next couple of days before it gets merged. -
Christian Kuhn commented on patch set 5 12/11/25, 21:03
BackendUtility.php:889i'm not a huge fan of this stupid helper, but it follows exactly the other ones we have for so long already, soo ... well. it is how it is. -
Garvin Hicking uploaded patch set 6
CR +1V +112/18/25, 05:58fix merge conflict -
core-ci voted on patch set 6 V +1 12/18/25, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92392
-
Georg Ringer voted on patch set 6 CR +1 V +1 12/18/25, 06:34
-
Benni Mack commented on patch set 6 12/18/25, 07:38
DefaultConfigurationDescription.yaml:93ReplyI wanted to write the same thing. However, I suggest we switch to one of the native "locale-formatted" time formats. -
Garvin Hicking commented on patch set 6 12/18/25, 07:46
DefaultConfigurationDescription.yaml:93ReplyJust for "H:i:s"? Because I know of no shorthand for it. And otherwise we'd lose the costumizatiin that ddhhyy offers analoguesy to datetime. Also we need no locale in H:i:s? -
Benni Mack commented on patch set 6 12/19/25, 08:27
DefaultConfigurationDescription.yaml:93ReplyDone -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/17/26, 10:59
-
Josua Vogel voted on patch set 6 V +1 01/17/26, 10:59
-
Josua Vogel voted on patch set 6 CR +1 01/17/26, 11:01
-
Garvin Hicking voted on patch set 6 CR +2 V +2 01/17/26, 11:13
-
Garvin Hicking merged patch set 7 01/17/26, 11:13